adds support for mongo-oidc #32
Conversation
huey-tlatoani
force-pushed
the
feature/mongo-oidc
branch
from
6547c1b to
e189b0f
Compare
IlyaEp
left a comment
IlyaEp
left a comment
There was a problem hiding this comment.
Thanks for contributing! I’ll have another look after we address or discuss the current issues
| for (String browser : browsers) { | ||
| try { | ||
| // Check if browser exists | ||
| Process process = runtime.exec(new String[] {"which", browser}); |
| * jdbc:mongodb://[username:password@]host1[:port1][,host2[:port2],...[,hostN[:portN]]][/[database][?options]] | ||
| * The URL excepting the jdbc: prefix is passed as it is to the MongoDb native Java driver. | ||
| */ | ||
| public class MongoJdbcDriver implements Driver { |
There was a problem hiding this comment.
The changes are hard to read because the diff includes unnecessary style edits (formatting, etc.). Please remove them or split the commits so that only the actual logic changes are visible
| */ | ||
| public String getDriverVersion() { | ||
| return "1.20"; | ||
| return "1.30"; |
There was a problem hiding this comment.
Do not update driver version
| shadowJar { | ||
| archiveFileName = "mongo-jdbc-standalone-${version}.jar" | ||
| mergeServiceFiles() | ||
| relocate 'com.nimbusds', 'shadow.com.nimbusds' |
There was a problem hiding this comment.
Please describe the purpose of this change
| ShellHolder shellHolder = this.shellHolder; | ||
| this.shellHolder = createShellHolder(); | ||
|
|
||
| var existingResult = Optional.ofNullable(this.mongoConnection) |
| public void start() throws IOException { | ||
| server = HttpServer.create(new InetSocketAddress(DEFAULT_REDIRECT_PORT), 0); | ||
|
|
||
| server.createContext("/callback", new CallbackHandler()); |
There was a problem hiding this comment.
You created a constant for '/accepted', but not for '/callback'. Why?
|
|
||
| import com.sun.net.httpserver.HttpExchange; | ||
| import com.sun.net.httpserver.HttpHandler; | ||
| import com.sun.net.httpserver.HttpServer; |
| } | ||
|
|
||
| public OidcResponse getOidcResponse() throws InterruptedException, OidcTimeoutException { | ||
| return getOidcResponse(Duration.ofSeconds(300)); |
| private @Nullable ExecutorService executorService; | ||
| private @Nullable Engine sharedEngine; | ||
| private @NotNull ShellHolder shellHolder; | ||
| private MongoConnection mongoConnection; |
There was a problem hiding this comment.
Do not cache the DB connection. If you need to cache the token, cache that instead
| return null; | ||
| } | ||
|
|
||
| Server server = new Server(); |
There was a problem hiding this comment.
Is it possible to bind the server lifecycle to the driver and initialize it lazily?
2 participants
No description provided.