Skip to content

Conversation

@cataphract
Copy link
Contributor

@cataphract cataphract commented Nov 10, 2025

Motivation

This test is passing. See also APMAPI-924

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/test_semantic_conventions.py                                      @DataDog/system-tests-core

@cataphract cataphract marked this pull request as ready for review November 10, 2025 16:05
@cataphract cataphract requested a review from a team as a code owner November 10, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants