Updates feature_id for feature flag test #5677
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
simon-id
approved these changes
Nov 6, 2025
uurien
reviewed
Nov 6, 2025
| https://feature-parity.us1.prod.dog/#/?feature=494 | ||
| """ | ||
| return _mark_test_object(test_object, feature_id=492, owner=_Owner.asm) | ||
| return _mark_test_object(test_object, feature_id=494, owner=_Owner.feature_flag_exposure) |
Contributor
There was a problem hiding this comment.
494 is for #494: DD_TRACE_ACTIVITY_LISTENER_ENABLED
uurien
requested changes
Nov 6, 2025
Contributor
uurien
left a comment
uurien
left a comment
There was a problem hiding this comment.
The feature id is for other feature
cbeauchesne
reviewed
Nov 12, 2025
Collaborator
cbeauchesne
left a comment
cbeauchesne
left a comment
There was a problem hiding this comment.
Could you get a review from one ASM member ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The feature_flag_exposure test was using a feature_id that was also assigned to an AppSec test, causing it to appear under AppSec in the feature parity dashboard
Changes
Updated the feature_id for the feature_flag_exposure test to the next available unique ID.