-
Notifications
You must be signed in to change notification settings - Fork 14
[nodejs] Enable resource renaming tests for Node.js #5675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "DD_LOGS_INJECTION": "true", | ||
| "DD_TRACE_RESOURCE_RENAMING_ENABLED": "true", | ||
| "DD_TRACE_RESOURCE_RENAMING_ALWAYS_SIMPLIFIED_ENDPOINT": "true", | ||
| "DD_TRACE_COMPUTE_STATS": "true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DD_TRACE_STATS_COMPUTATION_ENABLED is the right env var for all tracers
@florentinl
| "DD_TRACE_COMPUTE_STATS": "true", | ||
| "DD_TRACE_STATS_COMPUTATION_ENABLED": "true", | ||
| }, | ||
| appsec_enabled=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabling appsec will also enable resource renaming without the need of adding new env var and with the help of http.createServer flexibility that Node.js offers for Express/Fastify
|
|
|
Setting this PR as draft to unstress my notifications 😉 |
9fd6deb to
9fde0ef
Compare
Motivation
Enable resource renaming tests for Node.js on express and fastify weblogs
Ref: DataDog/dd-trace-js#6861
Changes
/resource_naminghandler in weblogsWorkflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present