-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize "edit" docs #3456
base: main
Are you sure you want to change the base?
Reorganize "edit" docs #3456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. I think we can merge after all comments have been resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't finished my review, we'll chat by zoom to discuss around the concpet of parametric vs end-to-end
@@ -1,6 +1,6 @@ | |||
Test items are skipped (or not) based on declarations in tests class, using manifest, or @bug/flaky/missing_feature decorators. | |||
|
|||
This fact implies an [egg-chicken issue](../edit/egg-chicken-changes.md) if you need to work on a feature. A way to handle it is to use the `-F` option : | |||
This fact implies an "[egg-chicken issue]"(../edit/egg-chicken-changes.md)[NOTE] if you need to work on a feature. A way to handle it is to use the `-F` option : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbeauchesne calling this out because I deleted the egg-chicken-changes doc. I moved info about how to approach the "chicken or the egg" problem to the enable-test doc. I could link it here instead, but to be honest I don't know what this force-execute doc is referring to and whether it's relevant? 🤔
Motivation
Make "edit" docs clearer
Changes
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present