Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang] Use /healthcheck to get library version #2955

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

cbeauchesne
Copy link
Collaborator

Motivation

#2799

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne changed the title [golang] Use HTTP interface for parametric tests [golang] Use /healthcheck to get library version Sep 2, 2024
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/golang-2799 branch 2 times, most recently from c4d599f to 0f29279 Compare September 9, 2024 17:04
@cbeauchesne cbeauchesne marked this pull request as ready for review September 9, 2024 19:54
@cbeauchesne cbeauchesne requested review from a team as code owners September 9, 2024 19:54
@cbeauchesne cbeauchesne merged commit a5473dd into main Sep 9, 2024
42 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/golang-2799 branch September 9, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant