Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking XPASS #2391

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Fix blocking XPASS #2391

merged 5 commits into from
Apr 25, 2024

Conversation

uurien
Copy link
Contributor

@uurien uurien commented Apr 25, 2024

Motivation

Improve our XPASS in blocking tests

Changes

Force execution of test_blocking() in test that are not expected to block, to prevent XPASS when a feature is not implemented.
Same approach that we made in IAST tests.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@uurien uurien marked this pull request as ready for review April 25, 2024 14:26
@uurien uurien requested review from a team as code owners April 25, 2024 14:26
@simon-id
Copy link
Member

Related with #2278, i'll see which ones are fixed by this PR.

@uurien uurien merged commit b86e1b5 into main Apr 25, 2024
301 of 302 checks passed
@uurien uurien deleted the ugaitz/node-blocking-easy-wins branch April 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants