-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
LANGTOOLS-2195 Start allowing configuration files (#56)
## Context Jira Issue: https://datadoghq.atlassian.net/browse/LANGTOOLS-2195 We've found that sometimes we want to create layers that have many arguments. Like when we have a ton of files to map. This ends up causing an issue where the underlying system cannot support so many arguments and it ends up failing. We're changing the `ocitool create-layer` command to accept a configuration file (in JSON format) that can be used to supply arguments to the command. There is technically a way to solve this problem without using a JSON file and making `ocitool create-layer` understand the different syntaxes that Bazel uses for param files: https://bazel.build/rules/lib/builtins/Args#use_param_file. Those syntaxes are hard to deal with, at best. They're written for a very specific type of CLI, and we don't seem to have an easy way to support that. Instead, we choose JSON as our format as it's ubiquitous, supported natively by Bazel (so we can say `json.encode(…)` in a rule), and supported by the Go stdlib (so we don't have to try hard to parse it). It's not a hard requirement, but it makes implemnting support trivial.
- Loading branch information
1 parent
707e411
commit 49db64d
Showing
2 changed files
with
60 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters