fix(skills): pi supports skills — add .pi/skills install paths#565
Merged
Conversation
pi.dev has supported skills since at least their current docs release (https://pi.dev/docs/latest/skills). The platform was incorrectly marked as extension-only, causing `pup skills install --name dd-apm pi` to fail with a misleading "pi only support extensions" error. - Set project_skills=".pi/skills", user_skills=".pi/agent/skills" in the pi PlatformSpec (matches the pi docs' canonical paths) - Remove stale comments and tests asserting pi is extension-only - Add tests verifying skills install to the correct pi paths, including a user-scope test covering the asymmetric .pi/agent/skills path Fixes #562 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🐑 PR Shepherd is maintaining this PRI watch your PR and automatically fix CI failures, rebase your branch, handle flaky tests, and push it to the merge queue when it's ready. More about what I do → Guide To pause me on this PR, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pi.dev supports skills (https://pi.dev/docs/latest/skills) but was incorrectly marked as extension-only in pup, causing
pup skills install --name dd-apm pito fail with a misleading error message. This PR fixes the platform spec and updates all affected tests.Changes
src/skills.rs:634-644— Setproject_skills=".pi/skills"anduser_skills=".pi/agent/skills"in the piPlatformSpec; remove stale comments calling pi extension-onlysrc/skills.rs— Replace tests asserting pi had no skills dir with tests verifying the correct project and user-scope paths, including a dedicated user-scope test for the asymmetric.pi/agent/skillspathsrc/commands/skills.rs— Replace three tests expecting extension-only errors for pi with tests verifying successful skill installationTesting
cargo test --bin pup -- --test-threads=1)cargo clippy -- -D warningscleancargo fmt --checkcleanRelated Issues
Closes #562
🤖 Generated with Claude Code