Guard against null heap profile #252
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 1.77 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2026-01-15 08:13:29 Comparing candidate commit 1c357cd in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 93 metrics, 27 unstable metrics. |
r1viollet
approved these changes
Jan 15, 2026
r1viollet
left a comment
r1viollet
left a comment
There was a problem hiding this comment.
LGTM
NIT: I think there could be a comment around why we suspect this is happening.
Example: Concurrent cleanup...
szegedi
added a commit
that referenced
this pull request
Jan 15, 2026
Merged
szegedi
added a commit
that referenced
this pull request
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Adds a check for whether the profile returned from
v8::HeapProfiler::GetAllocationProfile()is null and throws an exception when it is.Motivation:
We observed a crash in the wild at this location. It's possible we have a race condition between the cleanup hook and this method. Since the method is normally invoked once every ~60 seconds, the condition occurs very rarely. It's still better to throw an exception in JS (same as here before invoking the now modified method) than crash the process. dd-trace-js catches these exceptions and handles them gracefully.
Jira: PROF-13456