fix(libdd-trace-obfuscate): obfuscate HELLO|MIGRATE|ACL#1587
fix(libdd-trace-obfuscate): obfuscate HELLO|MIGRATE|ACL#1587duncanista wants to merge 3 commits intomainfrom
HELLO|MIGRATE|ACL#1587Conversation
📚 Documentation Check Results📦
|
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
🔒 Cargo Deny Results📦
|
There was a problem hiding this comment.
Pull request overview
Extends the Redis command obfuscation logic in libdd-trace-obfuscation to treat HELLO and MIGRATE like AUTH, replacing all arguments with ? to prevent sensitive data from appearing in span tags.
Changes:
- Add
HELLOandMIGRATEto the “obfuscate all args” command list in the Redis obfuscator. - Add unit tests covering
HELLO/MIGRATEwith and without arguments (including common variants).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
- Coverage 70.83% 70.83% -0.01%
==========================================
Files 423 423
Lines 61862 61867 +5
==========================================
- Hits 43823 43822 -1
- Misses 18039 18045 +6
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-02-17 18:52:06 Comparing candidate commit 31c4e09 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics. scenario:single_flag_killswitch/rules-based
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
jordan.gonzalez@datadoghq.com unqueued this merge request |
|
/remove |
|
View all feedbacks in Devflow UI.
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
HELLO|MIGRATEHELLO|MIGRATE|ACL
What does this PR do?
Motivation
Additional Notes
Mirror from DataDog/datadog-agent#46391 and DataDog/datadog-agent#46548
How to test the change?
Unit tests