chore(trace_exporter)!: remove Proxy TraceExporter input mode#1583
chore(trace_exporter)!: remove Proxy TraceExporter input mode#1583paullegranddc wants to merge 2 commits intomainfrom
Conversation
510b2a7 to
980213b
Compare
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 88e45ad | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
📚 Documentation Check Results📦
|
BenchmarksComparisonBenchmark execution time: 2026-02-18 10:41:02 Comparing candidate commit 88e45ad in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 2 unstable metrics. scenario:profile_add_sample2_frames_x1000
scenario:profile_add_sample_frames_x1000
scenario:single_flag_killswitch/rules-based
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
🔒 Cargo Deny Results📦
|
980213b to
919fcc4
Compare
| .set_language_interpreter_vendor("node") | ||
| .set_git_commit_sha("797e9ea") | ||
| .set_input_format(TraceExporterInputFormat::Proxy) | ||
| .set_input_format(TraceExporterInputFormat::V05) |
There was a problem hiding this comment.
I think this is causing these tests to fail. V0.5 -> V0.4 isn't allowed. It's probably fine to have the input/output match here?
| // previously used | ||
| _trace_count: usize, |
There was a problem hiding this comment.
Why can't you remove it ?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
==========================================
+ Coverage 70.82% 71.01% +0.19%
==========================================
Files 423 423
Lines 61845 61883 +38
==========================================
+ Hits 43802 43949 +147
+ Misses 18043 17934 -109
🚀 New features to boost your workflow:
|
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.