FFL-1255 Add feature flag evaluation library #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
==========================================
+ Coverage 71.74% 71.84% +0.10%
==========================================
Files 356 368 +12
Lines 56993 57967 +974
==========================================
+ Hits 40887 41648 +761
- Misses 16106 16319 +213
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2025-10-21 10:30:23 Comparing candidate commit 64681df in PR branch Found 7 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 2 unstable metrics. scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
scenario:redis/obfuscate_redis_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
dd-oleksii
changed the title
bantonsson
approved these changes
Oct 22, 2025
| } | ||
|
|
||
| #[test] | ||
| fn evaluation_sdk_test_data() { |
There was a problem hiding this comment.
It feels a bit weird that all the test cases are run inside a single method. I think it would be better to use a build.rs file to generate them. I'll open a small PR.
| impl Split { | ||
| /// Return `true` if `targeting_key` matches the given split. | ||
| /// | ||
| /// To match a split, subject must match all underlying shards. |
There was a problem hiding this comment.
It would be nice if there was some documentation that describes how the algorithm works. I see that there are shards, but how are they used.
leoromanovsky
approved these changes
Oct 22, 2025
| test_cases | ||
| } | ||
|
|
||
| fn bench_sdk_test_data_rules_based(b: &mut Bencher) { |
dd-devflow
bot
added
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding a feature-flagging evaluation library for use in Python/Ruby tracers.
Motivation
We're adding feature flags support in a bunch of tracers and want to use the common core in Python and Ruby (and any other tracer that can work with Rust).
Additional Notes
It's being moved over from dd-source. You can review it by commit. The first commit is a copy from dd-source, the next ones are dropping features we don't need / adapting to libdatadog.
How to test the change?
See inline tests.