Skip to content

feat: add native linear token admission - #115

Open
jbachorik wants to merge 1 commit into
agent/logs-reggie-l1dfrom
agent/logs-reggie-l1e
Open

feat: add native linear token admission#115
jbachorik wants to merge 1 commit into
agent/logs-reggie-l1dfrom
agent/logs-reggie-l1e

Conversation

@jbachorik

Copy link
Copy Markdown
Collaborator

Summary

  • adds a package-private, no-cache/no-fallback native named-LTS admission seam
  • returns structured profile, parsing, plan, and capture-coverage rejections
  • factors legacy named-only LTS routing through the same admission logic
  • verifies original group indexes, cache isolation, and concurrent matcher independence

Validation

  • ./gradlew jacocoVerify build
  • final implementation-plan validation and independent code review

Stacked on #114.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a package-private “native named-only LTS admission” seam in RuntimeCompiler that can return either an admitted LinearTokenSequenceMatcher or a structured rejection reason, and introduces tests to validate cache isolation, rejection taxonomy, capture index behavior, and matcher independence (including concurrency).

Changes:

  • Introduced NamedOnlyLtsRejection + NamedOnlyLtsCompilation and tryCompileNamedOnlyLinearTokenSequence(...) to return structured admission results without touching legacy caches.
  • Refactored the existing named-only LTS routing to share a single admission implementation (admitNamedOnlyLinearTokenSequence).
  • Added NamedOnlyLtsAdmissionTest to cover admissions, rejections, capture projection/index preservation, and concurrency behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
reggie-runtime/src/main/java/com/datadoghq/reggie/runtime/RuntimeCompiler.java Adds structured named-only LTS admission API and refactors admission logic to share the same implementation path.
reggie-runtime/src/test/java/com/datadoghq/reggie/runtime/NamedOnlyLtsAdmissionTest.java Adds coverage for cache isolation, rejection reasons, matcher independence, and capture-index preservation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbachorik
jbachorik marked this pull request as ready for review August 14, 2026 12:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 773d63b137

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jbachorik
jbachorik force-pushed the agent/logs-reggie-l1e branch from 773d63b to 74a0504 Compare August 14, 2026 13:05
@codecov-commenter

codecov-commenter commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.4%. Comparing base (f4bb496) to head (362ae27).

Files with missing lines Patch % Lines
.../com/datadoghq/reggie/runtime/RuntimeCompiler.java 86.9% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             agent/logs-reggie-l1d    #115   +/-   ##
=======================================================
  Coverage                     84.4%   84.4%           
  Complexity                       1       1           
=======================================================
  Files                          147     147           
  Lines                        43067   43087   +20     
  Branches                      5890    5891    +1     
=======================================================
+ Hits                         36367   36394   +27     
- Misses                        4905    4906    +1     
+ Partials                      1795    1787    -8     
Files with missing lines Coverage Δ
.../com/datadoghq/reggie/runtime/RuntimeCompiler.java 87.8% <86.9%> (+0.8%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4bb496...362ae27. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jbachorik
jbachorik force-pushed the agent/logs-reggie-l1e branch from 74a0504 to ce17323 Compare August 14, 2026 13:33
@jbachorik
jbachorik force-pushed the agent/logs-reggie-l1e branch from ce17323 to 362ae27 Compare August 14, 2026 13:42
@jbachorik
jbachorik requested a review from Zenithar August 14, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants