Skip to content

feat: add bounded char sequence LTS execution - #112

Open
jbachorik wants to merge 1 commit into
agent/logs-reggie-l1afrom
agent/logs-reggie-l1b
Open

feat: add bounded char sequence LTS execution#112
jbachorik wants to merge 1 commit into
agent/logs-reggie-l1afrom
agent/logs-reggie-l1b

Conversation

@jbachorik

Copy link
Copy Markdown
Collaborator

Summary

  • add an internal bounded LTS whole-match primitive over CharSequence.charAt()
  • preserve absolute capture spans and caller-array atomicity without materializing the input
  • make bounded LTS helpers respect the region end, including delimiter, HTTP-version, bracket-tail, and wildcard-tail paths
  • add guarded real expanded Grok fixture coverage for successful and failing nonzero regions

Why

This is the direct-execution prerequisite for using Reggie with logs-backend's interruptible input wrapper. It ensures matching cannot bypass deadline checks through String bulk operations or read outside the requested region.

Validation

  • ./gradlew :reggie-runtime:test --tests '*LinearTokenSequenceMatcherTest' --tests '*LinearTokenSequenceAccessLogTest' --tests '*LinearTokenSequenceMatcherConcurrencyTest'
  • ./gradlew jacocoVerify build

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21126de4b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jbachorik
jbachorik force-pushed the agent/logs-reggie-l1b branch from 21126de to 44e3604 Compare August 14, 2026 13:04
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.04762% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.4%. Comparing base (5d31eba) to head (44e3604).

Files with missing lines Patch % Lines
...ghq/reggie/runtime/LinearTokenSequenceMatcher.java 79.0% 2 Missing and 20 partials ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             agent/logs-reggie-l1a    #112   +/-   ##
=======================================================
  Coverage                     84.4%   84.4%           
  Complexity                       1       1           
=======================================================
  Files                          147     147           
  Lines                        42960   42991   +31     
  Branches                      5851    5859    +8     
=======================================================
+ Hits                         36260   36296   +36     
+ Misses                        4916    4906   -10     
- Partials                      1784    1789    +5     
Files with missing lines Coverage Δ
...ghq/reggie/runtime/LinearTokenSequenceMatcher.java 80.0% <79.0%> (+3.0%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d31eba...44e3604. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jbachorik
jbachorik requested a review from Zenithar August 14, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants