Skip to content

Fix botocore endpoint resolution by preserving top-level data files#23066

Draft
nubtron wants to merge 1 commit intomasterfrom
nubtron/custom-build/botocore-endpoint-fix
Draft

Fix botocore endpoint resolution by preserving top-level data files#23066
nubtron wants to merge 1 commit intomasterfrom
nubtron/custom-build/botocore-endpoint-fix

Conversation

@nubtron
Copy link
Contributor

@nubtron nubtron commented Mar 26, 2026

  • Add "!botocore/data/*.json" to files_to_remove.toml so that endpoints.json, partitions.json, _retry.json etc. are retained in built wheels. These files are required by botocore for AWS endpoint resolution and retry handling.
  • Add builder_changed input to workflow_dispatch so the builder image can be rebuilt from any branch without a push trigger.
  • Pass INPUT_BUILDER_CHANGED to resolve_deps_check_should_run.sh.
  • Add branch to publish job workflow_dispatch allowlist.
  • Remove Publish image and Save new image digest steps — image is built and used locally, no need to push to ghcr.io.
  • Set base on bot PR to target this branch, not master.

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

- Add "!botocore/data/*.json" to files_to_remove.toml so that
  endpoints.json, partitions.json, _retry.json etc. are retained in
  built wheels. These files are required by botocore for AWS endpoint
  resolution and retry handling.
- Add builder_changed input to workflow_dispatch so the builder image
  can be rebuilt from any branch without a push trigger.
- Pass INPUT_BUILDER_CHANGED to resolve_deps_check_should_run.sh.
- Add branch to publish job workflow_dispatch allowlist.
- Remove Publish image and Save new image digest steps — image is built
  and used locally, no need to push to ghcr.io.
- Set base on bot PR to target this branch, not master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant