ddev: add trusted _fetch_command secret resolution to config fields#23050
Draft
ddev: add trusted _fetch_command secret resolution to config fields#23050
Conversation
…ynamicD. This introduces trust-gated local override handling, actionable command-resolution errors, and centralized scrubbing so secret values and fetch-command fields are resolved safely and redacted consistently.
…ommand-secret loading lazy. This routes DynamicD key lookup through model-backed resolvers and aligns newly added files with 2026-present Datadog license headers.
This keeps parse_fields focused on type validation for fetch-command fields, while preserving on-demand resolution and extending hidden/scrubbed handling to trello.key.
Add public ddev docs for *_fetch_command secret fields, trust-gated .ddev.toml overrides, and config allow/deny usage, including troubleshooting and redaction guidance.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
Replace `echo ""` (prints literal `""` on Windows) and `/dev/null` redirection with `sys.executable`-based Python one-liners that produce the same behaviour on all platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*_fetch_commandconfig fields for all secret-bearing ddev config keys (github,pypi,trello,orgs.<name>,dynamicd), resolved lazily via shell command execution_fetch_commandfields in local.ddev.tomloverrides viaddev config allow/ddev config denycommandsddev config showoutputTest plan
command_resolver.py,override_trust.py,scrubber.py, config model changesconfig allow/config denyCLI commandsconfig showredaction behavior