Widen per-integration except clauses for library-agnostic HTTP exceptions#23046
Widen per-integration except clauses for library-agnostic HTTP exceptions#23046mwdd146980 wants to merge 1 commit intomwdd146980/step3b-fixture-swapfrom
Conversation
…ions Add library-agnostic exception types alongside existing requests-specific exceptions in 7 integrations, preparing for Step 3d's MockHTTPResponse migration. Also add HTTPInvalidURLError to the http_exceptions module. Integrations: elastic, fly_io, harbor, octopus_deploy, openstack_controller, proxmox, spark. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a039d8ce7b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| AgentHTTPConnectionError, | ||
| ) as e: | ||
| if isinstance(e, ConnectionError) and self._should_suppress_connection_error(e, tags): |
There was a problem hiding this comment.
This catch block now includes AgentHTTPConnectionError, but the suppression path still only runs when isinstance(e, ConnectionError) is true. If the library-agnostic HTTP layer raises AgentHTTPConnectionError (the new case this PR adds), _should_suppress_connection_error is never called, so transient/terminal-pod connection failures that should be debounced start emitting CRITICAL service checks and raising immediately. Please include the agent-specific connection error in the suppression check so behavior stays consistent.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
1 participant
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged