[DBMON-6301] Adding support for query errors in ClickHouse#23041
[DBMON-6301] Adding support for query errors in ClickHouse#23041sangeetashivaji wants to merge 3 commits intomasterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b14208aed8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 'database_instance': self._check.database_identifier, | ||
| 'ddagentversion': datadog_agent.get_version(), | ||
| 'ddsource': 'clickhouse', | ||
| 'dbm_type': 'query_errors', |
There was a problem hiding this comment.
Set dbm_type to the canonical singular value query_error; using query_errors here makes ClickHouse error batches inconsistent with the DBM activity taxonomy used elsewhere in this repo (for example SQL Server emits/consumes query_error), so downstream processors that route or filter by dbm_type will miss these events and the new feature will appear not to work.
Useful? React with 👍 / 👎.
sangeetashivaji
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
1 participant
What does this PR do?
In this PR, we want to support Query errors for all the queries that failed with exception or errors and did not complete. Exceptions include ExceptionBeforeStart, ExceptionWhileProcessing from the
system.query_logtableMotivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged