Fix botocore endpoint resolution by preserving top-level data files#23039
Open
piochelepiotr wants to merge 2 commits intomasterfrom
Open
Fix botocore endpoint resolution by preserving top-level data files#23039piochelepiotr wants to merge 2 commits intomasterfrom
piochelepiotr wants to merge 2 commits intomasterfrom
Conversation
PR #22283 used `botocore/data/*` to strip unused service models, but this also removed essential top-level files (endpoints.json, partitions.json, sdk-default-configuration.json, _retry.json) that botocore requires to function. This causes `DataNotFoundError: Unable to load data for: endpoints` breaking amazon_msk and kafka_consumer with MSK IAM auth. Change the pattern from `botocore/data/*` (matches everything) to `botocore/data/*/` (matches only subdirectories), so top-level files are preserved automatically without needing to enumerate them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37ffa88109
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The previous approach using `botocore/data/*/` was defeated by build_wheels.py's `is_excluded_from_wheel` which appends "/" to all paths before matching, causing files like endpoints.json/ to match a directory-only pattern. Instead, keep the original `botocore/data/*` glob and add a negation `!botocore/data/*.json` to explicitly preserve the top-level JSON files that botocore needs (endpoints.json, partitions.json, _retry.json, sdk-default-configuration.json). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
iliakur
approved these changes
Mar 25, 2026
JSGette
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
botocore/data/*to strip unused service models at build time, but this glob also matched essential top-level files (endpoints.json,partitions.json,sdk-default-configuration.json,_retry.json) that botocore needs to resolve any AWS service endpointbotocore/data/*(matches files and directories) tobotocore/data/*/(matches only subdirectories), so top-level files are preserved automaticallyDataNotFoundError: Unable to load data for: endpointsthat breaksamazon_mskandkafka_consumerwith MSK IAM authTest plan
botocore/data/endpoints.jsonis present in the output🤖 Generated with Claude Code