Adding new monitor template for ClickHouse#23027
Adding new monitor template for ClickHouse#23027sangeetashivaji wants to merge 1 commit intomasterfrom
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6761680dea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "timeout_h": 0 | ||
| }, | ||
| "priority": null, | ||
| "query": "avg(last_5m):avg:clickhouse.query.active{*} > 200", |
There was a problem hiding this comment.
Scope these ClickHouse alerts per host
This query creates a single aggregated alert across all hosts (avg:...{*} without by {host}), but the monitor name/message uses {{host.name}} and describes host-level symptoms. In multi-host deployments, one overloaded node can be averaged out by healthy nodes, so the alert may never fire even when a specific host is unhealthy, and the host template variable may be empty in notifications. The same pattern appears in the other newly added query monitors (clickhouse_high_query_failure_rate.json, clickhouse_high_thread_cpu_wait.json, clickhouse_merge_pool_saturation.json, and clickhouse_replica_delay.json).
Useful? React with 👍 / 👎.
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged