Skip to content

Adding new monitor template for ClickHouse#23027

Draft
sangeetashivaji wants to merge 1 commit intomasterfrom
sangeeta.shivajirao/clickhouse-monitor-templates
Draft

Adding new monitor template for ClickHouse#23027
sangeetashivaji wants to merge 1 commit intomasterfrom
sangeeta.shivajirao/clickhouse-monitor-templates

Conversation

@sangeetashivaji
Copy link
Copy Markdown
Contributor

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6761680dea

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

"timeout_h": 0
},
"priority": null,
"query": "avg(last_5m):avg:clickhouse.query.active{*} > 200",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Scope these ClickHouse alerts per host

This query creates a single aggregated alert across all hosts (avg:...{*} without by {host}), but the monitor name/message uses {{host.name}} and describes host-level symptoms. In multi-host deployments, one overloaded node can be averaged out by healthy nodes, so the alert may never fire even when a specific host is unhealthy, and the host template variable may be empty in notifications. The same pattern appears in the other newly added query monitors (clickhouse_high_query_failure_rate.json, clickhouse_high_thread_cpu_wait.json, clickhouse_merge_pool_saturation.json, and clickhouse_replica_delay.json).

Useful? React with 👍 / 👎.

@sangeetashivaji sangeetashivaji changed the title Adding new monitors for ClickHouse Adding new monitor template for ClickHouse Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant