-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBMON-4720 Part 1: Deprecate instance_config in database_metrics #19111
base: master
Are you sure you want to change the base?
Conversation
The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…s-core into allen.zhou-DBMON4720
The |
What does this PR do?
This PR deprecates usage of instance_config in favor of SQLServerConfig in database_metrics.
This is part 1 of DBMON-4720, a later PR will address the core of the ticket to make all database metrics configurable.
Motivation
Prevent passing instance_config unnecessarily down to SqlserverDatabaseMetricsBase objects, when it can all be handled in the initial configuration of SQLServerConfig.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged