Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBMON-4720 Part 1: Deprecate instance_config in database_metrics #19111

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

azhou-datadog
Copy link

What does this PR do?

This PR deprecates usage of instance_config in favor of SQLServerConfig in database_metrics.
This is part 1 of DBMON-4720, a later PR will address the core of the ticket to make all database metrics configurable.

Motivation

Prevent passing instance_config unnecessarily down to SqlserverDatabaseMetricsBase objects, when it can all be handled in the initial configuration of SQLServerConfig.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.54%. Comparing base (0c4e6a0) to head (04a50c9).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 91.08% <100.00%> (+9.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant