Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDMII-3168] Fix Citrix Profile #19059

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[NDMII-3168] Fix Citrix Profile #19059

wants to merge 2 commits into from

Conversation

dplepage-dd
Copy link

What does this PR do?

Fix a typo in one of our out-of-the-box SNMP profiles.

Metric tags using the old syntax (where OID and name are top-level instead part of Symbol) don't support the format specifier, and it gets silently ignored by the YAML loader.

From a user perspective, the only thing that will change is that anyone using citrix netscaler SDX devices will suddenly see a few tags that are IP addresses be formatted as such instead of as raw bytes.

Motivation

DataDog/datadog-agent#31054 revealed this issue.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (3fa69c8) to head (fd3ab43).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
snmp 95.71% <ø> (-0.02%) ⬇️
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dplepage-dd dplepage-dd changed the title Fix citrix profile. [NDMII-3168] Migrate OOTB profiles to the latest format Nov 15, 2024
@dplepage-dd dplepage-dd changed the title [NDMII-3168] Migrate OOTB profiles to the latest format [NDMII-3168] Fix Citrix Profile Nov 15, 2024
NouhaManai96
NouhaManai96 previously approved these changes Nov 15, 2024
Copy link
Contributor

@NouhaManai96 NouhaManai96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a release note/changelog ?

@dplepage-dd
Copy link
Author

My fix was tripping up the python validator and I don't have time to fix that right now, so I replaced it with a fix that just comments out the format block (which is being ignored anyway) and adds a todo to upgrade this to the newer structure and fix the format then. This shouldn't need a changelog now, because it shouldn't affect the behavior at all (the field was already being ignored by YAML when the struct was being loaded).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants