-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDMII-3168] Fix Citrix Profile #19059
base: master
Are you sure you want to change the base?
Conversation
320094e
to
ec8f7d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a release note/changelog ?
My fix was tripping up the python validator and I don't have time to fix that right now, so I replaced it with a fix that just comments out the format block (which is being ignored anyway) and adds a todo to upgrade this to the newer structure and fix the format then. This shouldn't need a changelog now, because it shouldn't affect the behavior at all (the field was already being ignored by YAML when the struct was being loaded). |
What does this PR do?
Fix a typo in one of our out-of-the-box SNMP profiles.
Metric tags using the old syntax (where OID and name are top-level instead part of Symbol) don't support the
format
specifier, and it gets silently ignored by the YAML loader.From a user perspective, the only thing that will change is that anyone using citrix netscaler SDX devices will suddenly see a few tags that are IP addresses be formatted as such instead of as raw bytes.
Motivation
DataDog/datadog-agent#31054 revealed this issue.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged