Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the verify option to clickhouse #19018

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

HadhemiDD
Copy link
Contributor

@HadhemiDD HadhemiDD commented Nov 8, 2024

What does this PR do?

Per customer request : #18862
Jira card: https://datadoghq.atlassian.net/browse/AI-4483

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (6e24929) to head (a947af7).
Report is 56 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
clickhouse 94.55% <100.00%> (+0.02%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

estherk15
estherk15 previously approved these changes Nov 8, 2024
@HadhemiDD HadhemiDD added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit fc8bd07 Nov 22, 2024
41 checks passed
@HadhemiDD HadhemiDD deleted the hadhemi/clickhouse-add-verify-flag branch November 22, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants