-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(error-tracking): add settings for backend standalone #1625
base: main
Are you sure you want to change the base?
feat(error-tracking): add settings for backend standalone #1625
Conversation
25b074e
to
876930c
Compare
@@ -1519,6 +1524,11 @@ agents: | |||
## get guaranteed delivery of the metrics in Datadog-per-namespace setup! | |||
enabled: true | |||
|
|||
## Settings for the core agent | |||
coreAgent: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn’t seem ideal to base the activation or deactivation of a feature on a container name (coreAgent). While this approach has been used in the past, we are now aiming to define settings names based on the end-user feature rather than internal or technical details.
Additionally, the proposed setting name feels too generic. It would be preferable to use a name that is both clear and self-explanatory. For example, something along the lines of agents.payloadForwarder.enabled
or, considering the functionality in the datadog-agent codebase, agents.metricsForwarder.enabled
might be more appropriate.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t feel knowledgeable enough yet about this new APM feature to recommend the best approach for enabling the "error tracking standalone" functionality.
However, if the APM team intends to reuse the datadog
Helm chart while enabling only this APM feature, simply disabling the metrics forwarder doesn’t seem optimal. This is because several other functionalities currently run by default in the core-agent or process-agent container and would continue to execute within the core-agent process, consuming CPU and memory resources unnecessarily. We also run by default the cluster-agent component.
What this PR does / why we need it:
Exposes new settings available for the agent:
agents.coreAgent.enabled
controls Add infra agent config option datadog-agent#30137datadog.apm.errorTrackingStandalone.enabled
controls Add Error Tracking Standalone Config option datadog-agent#30065The equivalent for the operator will be done in a separate PR.
Checklist
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md
make update-test-baselines
)