Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set otelcollector.config to string #1609

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dineshg13
Copy link
Member

@dineshg13 dineshg13 commented Nov 18, 2024

What this PR does / why we need it:

Sets the config type to string instead of null, where we lose the type.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Nov 18, 2024
@dineshg13 dineshg13 marked this pull request as ready for review November 20, 2024 17:42
@dineshg13 dineshg13 requested a review from a team as a code owner November 20, 2024 17:42
@dineshg13 dineshg13 changed the title feedback set config to string set otelcollector.config to string Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant