Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clusterChecksRunner) Add hostaliases to clusterchecksrunner #1604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LFSb
Copy link

@LFSb LFSb commented Nov 11, 2024

What this PR does / why we need it:

We want to enable the TLS integration as a clustercheck, but we need to point it to some endpoints that are not present in our DNS.

An alternative solution is to implement the TLS test through a synthetic test runner (where hostAliases are available), but this solution is better from a self-service perspective.

Special notes for your reviewer:

I pretty much copy-pasted the contents of this. This is my first time contributing, so let me know if I could have done anything better the next time 🙂

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@LFSb LFSb requested a review from a team as a code owner November 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant