Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBAC to DCA if datadog.secretBackend.roles enabled #1513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tbavelier
Copy link
Member

@tbavelier tbavelier commented Aug 30, 2024

What this PR does / why we need it:

  • Similar to the node Agent, creates necessary RBAC for the DCA to read secrets when datadog.secretBackend.roles is specified.
  • Previously, we would not create permissions for the DCA, preventing secrets resolution for cluster checks that requires k8s secrets (e.g. using the helper "/readsecret_multiple_providers.sh"), and the cluster checks would be sent to runners with ENC[] (encrypted value) instead of being decoded by DCA before being sent over
  • Found by @fanny-jiang when reviewing [CECO-743] Secrets backend feature datadog-operator#1333

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Aug 30, 2024
@tbavelier tbavelier marked this pull request as ready for review August 30, 2024 13:35
@tbavelier tbavelier requested a review from a team as a code owner August 30, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant