add nodeAnnotationsAsTags configuration option #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chart/datadog
adel121
force-pushed
the
adelhajhassan/add_node_annotations_as_tags_configuration_option
branch
from
f52633c
to
d2b6c1a
Compare
davidor
reviewed
Aug 8, 2024
| @@ -233,6 +233,12 @@ datadog: | |||
| # kubernetes.io/role: kube_role | |||
| # <KUBERNETES_NODE_LABEL>: <DATADOG_TAG_KEY> | |||
|
|
|||
| # datadog.nodeAnnotationsAsTags -- Provide a mapping of Kubernetes Node Annotations to Datadog Tags | |||
| nodeAnnotationsAsTags: | |||
| cluster.k8s.io/machine: kube_machine | |||
There was a problem hiding this comment.
I intend to have this as a default value
There was a problem hiding this comment.
It might be better to not set any default here and let the one in the agent apply if there's no value specified here.
davidor
reviewed
Aug 8, 2024
| @@ -233,6 +233,12 @@ datadog: | |||
| # kubernetes.io/role: kube_role | |||
| # <KUBERNETES_NODE_LABEL>: <DATADOG_TAG_KEY> | |||
|
|
|||
| # datadog.nodeAnnotationsAsTags -- Provide a mapping of Kubernetes Node Annotations to Datadog Tags | |||
| nodeAnnotationsAsTags: | |||
There was a problem hiding this comment.
This option is not used in any template
There was a problem hiding this comment.
My bad, missed adding the template file before committing.
updated.
adel121
force-pushed
the
adelhajhassan/add_node_annotations_as_tags_configuration_option
branch
from
d2b6c1a
to
c43d19e
Compare
davidor
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
Adds
nodeAnnotationsAsTagsconfiguration option to the datadog chart.Special notes for your reviewer:
This configuration option was introduced some time ago in this PR but was not introduced yet in helm chart.
An similar option, nodeLabelsAsTags, is already present in helm.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)