Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the startupProbe parameter for older Kubernetes clusters that don't support startupProbes #1481

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mrdoggopat
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes

  • Remove startupProbe for older Kubernetes clusters as the support for these started with v1.18
  • For customers with ArgoCD, it'll always show a diff in the application because the field is not available for older clusters.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Aug 7, 2024
@mrdoggopat mrdoggopat changed the title Mrmcpat startupprobe Remove the startupProbe parameter for older Kubernetes clusters that don't support startupProbes Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant