Joseph.borkowski/syn 5024#37829
Conversation
…es from .variables.extracted. to .result.
Preview links (active after the
|
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 Automated review by Claude. AI-generated; verify before acting.
This PR is a clean rename from synthetics.attributes.variables.extracted.* to synthetics.attributes.result.* across the API testing template variables page, plus removal of the step-details section (which doesn't apply to API tests) and a new dedicated synthetics_variables_api_options group.
A few small nits below — nothing blocking. Worth noting that the Browser, Mobile, and Multistep template-variable pages still use the old synthetics.attributes.variables.extracted.* paths; this PR is scoped to API tests, so that asymmetry is presumably intentional, but flagging it in case a follow-up sweep is planned.
Reviewed e83ddb7d86b414dba028c2fbd90839c8e263fff1 — workflow run
|
|
||
| {% /if %} | ||
| <!-- END Step details variables --> | ||
|
|
There was a problem hiding this comment.
Style: Removing the <!-- Step details variables --> block left an extra blank line here. There are now two consecutive blank lines between <!-- END Test info variables --> and <!-- Variables --> — collapse to one for consistency with the other section separators in this file.
There was a problem hiding this comment.
I can only run on private repositories.
| - id: test_results | ||
| default: true | ||
| - id: test_info | ||
| - id: local_and_global No newline at end of file |
There was a problem hiding this comment.
Style: Missing trailing newline at end of file (\ No newline at end of file in the diff). Add a final newline to satisfy POSIX/YAML conventions and avoid noisy diffs in future edits.
|
Created DOCS-14987 for review. |
2 participants
What does this PR do?
step_detailssection from API tests where it doesn't applysynthetics.attributes.variables.extracted.ping.latency.avg->synthetics.attributes.result.ping.latency.avgWhat is the motivation?
Our current documentation for API tests is incorrect and gives customers the wrong variable paths to use in their monitor notifications.
Merge readiness
For Datadog employees:
<name>/<description>convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR./reviewto run an automated check that catches common issues before a Documentation team member reviews your PR.AI assistance
Additional notes