-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Unified Service Tagging cleanup for KSM, global env, version #36678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+75
−116
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e8e46a8
Remove KSM specific steps and cleanup k8s basic handling
JacksonDavenport 70142a8
Add global env level info to k8s
JacksonDavenport 1865c2e
Consolidate container image version tagging outside of tabs
JacksonDavenport 1ed6b72
Apply suggestions from code review
JacksonDavenport d6a6261
Add further recommendations
JacksonDavenport ed2c3d9
Clarify the labels and env var handling
JacksonDavenport File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the use of "following" here confusing, because we don't list the labels; we talk about environment variables instead. Can we clarify the relationship between them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted a bit and added those labels, but not sure if it looks too lengthy. But does that look more clear?
In general the labels are for the infrastructure side (metrics, logs, pod/container tagging) where as the env vars are largely just used by the Datadog tracers for the traces and spans.