-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix indent in Android SDK snippets #34144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
11dde40 to
15c1160
Compare
|
Checked |
buraizu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @0xnm, this LGTM and approving. Could you please confirm that you're ready to merge this PR, and you're not waiting on any additional reviews? Just asking because:
- Some of the changes are not related to indentation
- It's not marked as ready for merge
Thanks!
|
@buraizu Thanks for reviewing! It is ready to be merged. |
15c1160 to
9fd7ea1
Compare
9fd7ea1 to
4ea82a8
Compare
What does this PR do? What is the motivation?
Some snippets for Android SDK have redundant extra indent which can be safely removed, removing the need to scroll horizontally in some cases.
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes