Clarify dd.trace.config limitations for enabling Java Profiler and Dynamic Instrumentation #33594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added note about not relying solely on dd.trace.config for SDK-dependent products.
Contributor
Preview links (active after the
|
git-thuerk-done
approved these changes
Dec 29, 2025
Contributor
git-thuerk-done
left a comment
git-thuerk-done
left a comment
There was a problem hiding this comment.
Just a minor nit but approved!
| **Default**: `null`<br> | ||
| Optional path to a file where configuration properties are provided one per each line. For instance, the file path can be provided as via `-Ddd.trace.config=<FILE_PATH>.properties`, with setting the service name in the file with `dd.service=<SERVICE_NAME>` | ||
| Optional path to a file where configuration properties are provided one per each line. For instance, the file path can be provided as via `-Ddd.trace.config=<FILE_PATH>.properties`, with setting the service name in the file with `dd.service=<SERVICE_NAME>`<br> | ||
| **Note**: Don’t rely on `dd.trace.config` as the only mechanism to enable or disable SDK-dependent products (for example, Profiler and Dynamic Instrumentation). Prefer the corresponding system properties or environment variables (or `application_monitoring.yaml` for Single Step Instrumentation). |
Contributor
There was a problem hiding this comment.
Suggested change
| **Note**: Don’t rely on `dd.trace.config` as the only mechanism to enable or disable SDK-dependent products (for example, Profiler and Dynamic Instrumentation). Prefer the corresponding system properties or environment variables (or `application_monitoring.yaml` for Single Step Instrumentation). | |
| **Note**: Don't rely on `dd.trace.config` as the only mechanism to enable or disable SDK-dependent products (for example, Profiler and Dynamic Instrumentation). Refer to the corresponding system properties or environment variables (or `application_monitoring.yaml` for Single Step Instrumentation). |
Not sure if this should say "Refer to" as "Prefer" didn't quite make sense ? Also it might help to link to the application_monitoring.yaml on the SSI page ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note about not relying solely on dd.trace.config for SDK-dependent products.
What does this PR do? What is the motivation?
dd.trace.configvalues may appear “enabled” in the startup output even though the product does not actually start.Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes