-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add permissions section for adaptive sampling #32234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add permissions section for adaptive sampling #32234
Conversation
Added permissions section for adaptive sampling configuration, detailing user roles and access restrictions.
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions and comments! Hit me up when ready for re-review.
By default, only users with the `Datadog Admin` role can modify adaptive sampling configurations or onboard services to adaptive sampling. | ||
To make changes, ensure your user account is upgraded to the default `Datadog Admin` role. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the second sentence is implied by the first.
By default, only users with the `Datadog Admin` role can modify adaptive sampling configurations or onboard services to adaptive sampling. | |
To make changes, ensure your user account is upgraded to the default `Datadog Admin` role. | |
By default, only users with the `Datadog Admin` role can modify adaptive sampling configurations or onboard services to adaptive sampling. |
If your organization uses custom roles, assign your user to a custom role that includes `APM Remote Configuration Write` and `APM Service Ingest Write` [permissions.][4] | ||
|
||
### Restrict access | ||
Use [granular access controls][19] to manage who can modify a specific service’s adaptive sampling configuration. You can restrict access based on roles, teams or individual users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use [granular access controls][19] to manage who can modify a specific service’s adaptive sampling configuration. You can restrict access based on roles, teams or individual users. | |
Use [granular access controls][19] to manage who can modify a service's adaptive sampling configuration. You can restrict access based on roles, teams, or individual users. |
|
||
2. Click **Restrict access**. | ||
|
||
3. Select the teams, roles or users to grant access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3. Select the teams, roles or users to grant access. | |
3. Select the teams, roles, or users to grant access to. |
|
||
4. Click **Add**. | ||
|
||
Note: Only users with the `remote_config_write` permission can restrict access to the adaptive sampling configuration of individual services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Only users with the `remote_config_write` permission can restrict access to the adaptive sampling configuration of individual services. | |
**Note**: Only users with the `remote_config_write` permission can restrict access to the adaptive sampling configuration of individual services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend moving this note higher up. I think it's important people are aware of this limitation prior to going through the steps.
### Restrict access | ||
Use [granular access controls][19] to manage who can modify a specific service’s adaptive sampling configuration. You can restrict access based on roles, teams or individual users. | ||
|
||
{{< img src="/tracing/guide/adaptive_sampling/add_restriction.png" alt="Restrict permission" style="width:100%;">}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images aren't rendering. I don't see them in the /tracing/guide/adaptive_sampling
folder either on my local machine... Did you mean to add the images to this PR?
Added permissions section for adaptive sampling configuration, detailing user roles and access restrictions.
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes