Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Defer tooltip script loading until after HTML is parsed #26923

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brett0000FF
Copy link
Contributor

@brett0000FF brett0000FF commented Dec 30, 2024

What does this PR do? What is the motivation?

  • The tooltip functionality wasn't initializing on first page load in Chrome.
  • After refreshing the page, it works as expected.
  • This only started happening recently in Chrome.
  • Added defer to script initialization in footer-scripts.html to make sure the HTML is parsed before the script runs.

Test instructions

  1. Go to a page using a tooltip.
  2. Make sure it displays on hover immediately.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@brett0000FF brett0000FF requested a review from a team as a code owner December 30, 2024 18:39
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Dec 30, 2024
@brett0000FF brett0000FF marked this pull request as draft December 30, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant