Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express 5 is not supported for Node.js #26321

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

brett0000FF
Copy link
Contributor

@brett0000FF brett0000FF commented Nov 15, 2024

What does this PR do? What is the motivation?

  • Express 5 was released, which we do not support (raised by support team).
  • This makes the current entry >4 invalid.
  • Change the cell to say 4.x to encompass all 4.0 and all minor versions.

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@brett0000FF brett0000FF requested a review from a team as a code owner November 15, 2024 17:38
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@brett0000FF
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 15, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-15 20:56:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-15 20:56:17 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-15 23:39:22 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 29m.

@dd-mergequeue dd-mergequeue bot merged commit 2327f93 into master Nov 16, 2024
22 of 28 checks passed
@dd-mergequeue dd-mergequeue bot deleted the brett0000FF/node-compatibility branch November 16, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants