Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Action with JRuby9.2, Rails 4 exception #4159

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

TonyCTHsu
Copy link
Contributor

https://github.com/DataDog/dd-trace-rb/actions/runs/12011727682/job/33481379194

What does this PR do?

Update with an exception case which was absent from matrix

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 25, 2024 14:41
@TonyCTHsu TonyCTHsu added the dev/internal Other internal work that does not need to be included in the changelog label Nov 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (7f72e43) to head (ed6ea7f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4159   +/-   ##
=======================================
  Coverage   97.78%   97.79%           
=======================================
  Files        1350     1350           
  Lines       81399    81399           
  Branches     4109     4109           
=======================================
+ Hits        79598    79601    +3     
+ Misses       1801     1798    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pr-commenter
Copy link

pr-commenter bot commented Nov 25, 2024

Benchmarks

Benchmark execution time: 2024-11-25 15:23:44

Comparing candidate commit ed6ea7f in PR branch tonycthsu/fix-action-for-jruby with baseline commit 7f72e43 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Trace Context

  • 🟩 throughput [+3460.181op/s; +3569.448op/s] or [+10.013%; +10.329%]

scenario:tracing - Tracing.log_correlation

  • 🟩 throughput [+7344.746op/s; +7657.062op/s] or [+6.657%; +6.940%]

tasks/edge.rake Outdated Show resolved Hide resolved
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/fix-action-for-jruby branch from ed6ea7f to 2765792 Compare November 25, 2024 15:57
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks reasonable!

@TonyCTHsu TonyCTHsu merged commit 5b73da4 into master Nov 25, 2024
281 of 283 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/fix-action-for-jruby branch November 25, 2024 16:26
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants