Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-2334 test argument squashing into hashes on ruby 2 #4157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

p-datadog
Copy link
Contributor

@p-datadog p-datadog commented Nov 25, 2024

What does this PR do?
Adds test coverage for Ruby 2 pattern of defining a method with an "options" last argument that keyword arguments are squashed into.

Motivation:
Additional test coverage for DI.

Change log entry
None

Additional Notes:

How to test the change?
Unit tests are included.

@p-datadog p-datadog requested a review from a team as a code owner November 25, 2024 04:19
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Nov 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.77%. Comparing base (e703220) to head (d33df9f).

Files with missing lines Patch % Lines
spec/datadog/di/hook_method.rb 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4157      +/-   ##
==========================================
+ Coverage   97.76%   97.77%   +0.01%     
==========================================
  Files        1350     1350              
  Lines       81327    81381      +54     
  Branches     4107     4109       +2     
==========================================
+ Hits        79508    79571      +63     
+ Misses       1819     1810       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pr-commenter
Copy link

pr-commenter bot commented Nov 25, 2024

Benchmarks

Benchmark execution time: 2024-11-25 05:02:26

Comparing candidate commit d33df9f in PR branch di-hash-squash with baseline commit e703220 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants