Skip to content

chore(profiling): increase ref before stealing #15031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2025
Merged

chore(profiling): increase ref before stealing #15031

merged 4 commits into from
Oct 28, 2025
+3 −3

Conversation

@taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Oct 24, 2025 •
edited
Loading

Description

Noticed this while looking into crashes related to the memory profiler. See notebook here. We are not sure whether this would be root cause of such crashes, but still think it's 'logically' correct to increment the reference before calling PyTuple_SET_ITEM().

When you call PyTuple_SET_ITEM(p, pos, obj);, then the ownership of the object o is transferred to the tuple.

Stealing a reference means that when you pass a reference to a function, that function assumes that it now owns that reference, and you are not responsible for it any longer

When you want to keep using an object although the reference to it will be stolen, use Py_INCREF() to grab another reference before calling the reference-stealing function.

Testing

Risks

Additional Notes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

CODEOWNERS have been resolved as:

ddtrace/profiling/collector/_memalloc_tb.c                              @DataDog/profiling-python

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 237 ± 2 ms.

The average import time from base is: 239 ± 2 ms.

The import time difference between this PR and base is: -2.2 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.058 ms (0.87%)
ddtrace.bootstrap.sitecustomize 1.321 ms (0.56%)
ddtrace.bootstrap.preload 1.321 ms (0.56%)
ddtrace.internal.remoteconfig.client 0.638 ms (0.27%)
ddtrace 0.737 ms (0.31%)
ddtrace._logger 0.059 ms (0.02%)
ddtrace.internal.telemetry 0.059 ms (0.02%)
ddtrace.settings._agent 0.059 ms (0.02%)
ddtrace.settings._core 0.059 ms (0.02%)
ddtrace.internal.native 0.059 ms (0.02%)
ddtrace.internal.native._native 0.059 ms (0.02%)
ddtrace.internal._unpatched 0.029 ms (0.01%)
json 0.029 ms (0.01%)
json.decoder 0.029 ms (0.01%)
re 0.029 ms (0.01%)
enum 0.029 ms (0.01%)
types 0.029 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Oct 24, 2025 •
edited
Loading

Performance SLOs

Comparing candidate taegyunkim/tuple-incref (9b31172) with baseline main (2d1058c)

📈 Performance Regressions (1 suite)
📈 iastaspects - 118/118

✅ add_aspect

Time: ✅ 0.412µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +2.4%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ add_inplace_aspect

Time: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.4%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ add_inplace_noaspect

Time: ✅ 0.314µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -0.3%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ add_noaspect

Time: ✅ 0.274µs (SLO: <10.000µs 📉 -97.3%) vs baseline: -1.5%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ bytearray_aspect

Time: ✅ 1.493µs (SLO: <10.000µs 📉 -85.1%) vs baseline: +9.8%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ bytearray_extend_aspect

Time: ✅ 1.514µs (SLO: <10.000µs 📉 -84.9%) vs baseline: -1.3%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ bytearray_extend_noaspect

Time: ✅ 0.613µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.4%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8%

✅ bytearray_noaspect

Time: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.8%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ bytes_aspect

Time: ✅ 1.297µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +1.1%

Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.8%

✅ bytes_noaspect

Time: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.2%

Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +4.9%

✅ bytesio_aspect

Time: ✅ 1.354µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +0.8%

Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.2%

✅ bytesio_noaspect

Time: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ capitalize_aspect

Time: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.3%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.8%

✅ capitalize_noaspect

Time: ✅ 0.432µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.8%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ casefold_aspect

Time: ✅ 0.735µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.7%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ casefold_noaspect

Time: ✅ 0.365µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.9%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ decode_aspect

Time: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.5%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ decode_noaspect

Time: ✅ 0.421µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.1%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ encode_aspect

Time: ✅ 0.708µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.8%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.8%

✅ encode_noaspect

Time: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.4%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.7%

✅ format_aspect

Time: ✅ 3.412µs (SLO: <10.000µs 📉 -65.9%) vs baseline: +0.4%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ format_map_aspect

Time: ✅ 3.657µs (SLO: <10.000µs 📉 -63.4%) vs baseline: -0.5%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ format_map_noaspect

Time: ✅ 0.776µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.5%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ format_noaspect

Time: ✅ 0.597µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.1%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ index_aspect

Time: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +1.5%

Memory: ✅ 38.004MB (SLO: <39.000MB -2.6%) vs baseline: +4.5%

✅ index_noaspect

Time: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.5%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ join_aspect

Time: ✅ 1.355µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -0.4%

Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.6%

✅ join_noaspect

Time: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.2%

Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0%

✅ ljust_aspect

Time: ✅ 2.567µs (SLO: <20.000µs 📉 -87.2%) vs baseline: +0.3%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ ljust_noaspect

Time: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.5%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ lower_aspect

Time: ✅ 2.200µs (SLO: <10.000µs 📉 -78.0%) vs baseline: +1.0%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ lower_noaspect

Time: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.9%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ lstrip_aspect

Time: ✅ 2.239µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +1.4%

Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7%

✅ lstrip_noaspect

Time: ✅ 0.386µs (SLO: <10.000µs 📉 -96.1%) vs baseline: ~same

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ modulo_aspect

Time: ✅ 0.989µs (SLO: <10.000µs 📉 -90.1%) vs baseline: -0.6%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 1.555µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.5%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ modulo_aspect_for_bytes

Time: ✅ 0.976µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.1%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.8%

✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 1.213µs (SLO: <10.000µs 📉 -87.9%) vs baseline: -0.7%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ modulo_noaspect

Time: ✅ 0.630µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.5%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ replace_aspect

Time: ✅ 5.054µs (SLO: <10.000µs 📉 -49.5%) vs baseline: +1.9%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ replace_noaspect

Time: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.7%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ repr_aspect

Time: ✅ 0.907µs (SLO: <10.000µs 📉 -90.9%) vs baseline: -0.2%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8%

✅ repr_noaspect

Time: ✅ 0.412µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.5%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ rstrip_aspect

Time: ✅ 1.907µs (SLO: <20.000µs 📉 -90.5%) vs baseline: +0.2%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ rstrip_noaspect

Time: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.7%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ slice_aspect

Time: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.8%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ slice_noaspect

Time: ✅ 0.445µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.2%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ stringio_aspect

Time: ✅ 1.579µs (SLO: <10.000µs 📉 -84.2%) vs baseline: ~same

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ stringio_noaspect

Time: ✅ 0.711µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -1.2%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ strip_aspect

Time: ✅ 2.504µs (SLO: <20.000µs 📉 -87.5%) vs baseline: 📈 +13.8%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ strip_noaspect

Time: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.6%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ swapcase_aspect

Time: ✅ 2.398µs (SLO: <10.000µs 📉 -76.0%) vs baseline: +0.2%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ swapcase_noaspect

Time: ✅ 0.535µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -0.5%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ title_aspect

Time: ✅ 2.316µs (SLO: <10.000µs 📉 -76.8%) vs baseline: +0.7%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.7%

✅ title_noaspect

Time: ✅ 0.506µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +1.8%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ translate_aspect

Time: ✅ 3.259µs (SLO: <10.000µs 📉 -67.4%) vs baseline: +0.5%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8%

✅ translate_noaspect

Time: ✅ 1.040µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.3%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ upper_aspect

Time: ✅ 2.179µs (SLO: <10.000µs 📉 -78.2%) vs baseline: -0.5%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ upper_noaspect

Time: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.9%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.6%

🟡 Near SLO Breach (6 suites)
🟡 djangosimple - 30/30

✅ appsec

Time: ✅ 20.491ms (SLO: <22.300ms -8.1%) vs baseline: ~same

Memory: ✅ 66.473MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9%

✅ exception-replay-enabled

Time: ✅ 1.342ms (SLO: <1.450ms -7.4%) vs baseline: -0.2%

Memory: ✅ 64.669MB (SLO: <67.000MB -3.5%) vs baseline: +4.8%

✅ iast

Time: ✅ 20.529ms (SLO: <22.250ms -7.7%) vs baseline: +0.3%

Memory: ✅ 66.445MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8%

✅ profiler

Time: ✅ 15.535ms (SLO: <16.550ms -6.1%) vs baseline: +0.4%

Memory: ✅ 54.084MB (SLO: <54.500MB 🟡 -0.8%) vs baseline: +4.8%

✅ resource-renaming

Time: ✅ 20.541ms (SLO: <21.750ms -5.6%) vs baseline: -0.2%

Memory: ✅ 66.465MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9%

✅ span-code-origin

Time: ✅ 25.139ms (SLO: <28.200ms 📉 -10.9%) vs baseline: -1.2%

Memory: ✅ 67.625MB (SLO: <69.500MB -2.7%) vs baseline: +5.0%

✅ tracer

Time: ✅ 20.459ms (SLO: <21.750ms -5.9%) vs baseline: -0.1%

Memory: ✅ 66.426MB (SLO: <67.000MB 🟡 -0.9%) vs baseline: +4.9%

✅ tracer-and-profiler

Time: ✅ 22.684ms (SLO: <23.500ms -3.5%) vs baseline: ~same

Memory: ✅ 67.881MB (SLO: <68.000MB 🟡 -0.2%) vs baseline: +4.8%

✅ tracer-dont-create-db-spans

Time: ✅ 19.348ms (SLO: <21.500ms 📉 -10.0%) vs baseline: -0.2%

Memory: ✅ 66.352MB (SLO: <67.000MB 🟡 -1.0%) vs baseline: +4.7%

✅ tracer-minimal

Time: ✅ 16.586ms (SLO: <17.500ms -5.2%) vs baseline: ~same

Memory: ✅ 66.432MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9%

✅ tracer-native

Time: ✅ 20.503ms (SLO: <21.750ms -5.7%) vs baseline: ~same

Memory: ✅ 72.210MB (SLO: <72.500MB 🟡 -0.4%) vs baseline: +4.9%

✅ tracer-no-caches

Time: ✅ 18.493ms (SLO: <19.650ms -5.9%) vs baseline: ~same

Memory: ✅ 66.407MB (SLO: <67.000MB 🟡 -0.9%) vs baseline: +4.8%

✅ tracer-no-databases

Time: ✅ 18.779ms (SLO: <20.100ms -6.6%) vs baseline: +0.1%

Memory: ✅ 66.511MB (SLO: <67.000MB 🟡 -0.7%) vs baseline: +4.9%

✅ tracer-no-middleware

Time: ✅ 20.206ms (SLO: <21.500ms -6.0%) vs baseline: ~same

Memory: ✅ 66.444MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8%

✅ tracer-no-templates

Time: ✅ 20.267ms (SLO: <22.000ms -7.9%) vs baseline: -0.4%

Memory: ✅ 66.433MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8%

🟡 errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 18.163ms (SLO: <19.850ms -8.5%) vs baseline: +0.9%

Memory: ✅ 66.391MB (SLO: <66.500MB 🟡 -0.2%) vs baseline: +4.8%

✅ errortracking-enabled-user

Time: ✅ 18.125ms (SLO: <19.400ms -6.6%) vs baseline: +0.4%

Memory: ✅ 66.408MB (SLO: <66.500MB 🟡 -0.1%) vs baseline: +4.8%

✅ tracer-enabled

Time: ✅ 18.163ms (SLO: <19.450ms -6.6%) vs baseline: +0.5%

Memory: ✅ 66.357MB (SLO: <66.500MB 🟡 -0.2%) vs baseline: +4.8%

🟡 errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.070ms (SLO: <2.300ms -10.0%) vs baseline: +0.2%

Memory: ✅ 52.770MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +4.6%

✅ errortracking-enabled-user

Time: ✅ 2.074ms (SLO: <2.250ms -7.8%) vs baseline: +0.2%

Memory: ✅ 52.848MB (SLO: <53.500MB 🟡 -1.2%) vs baseline: +4.6%

✅ tracer-enabled

Time: ✅ 2.071ms (SLO: <2.300ms -9.9%) vs baseline: +0.1%

Memory: ✅ 52.789MB (SLO: <53.500MB 🟡 -1.3%) vs baseline: +4.6%

🟡 flasksimple - 18/18

✅ appsec-get

Time: ✅ 4.594ms (SLO: <4.750ms -3.3%) vs baseline: -0.3%

Memory: ✅ 62.738MB (SLO: <65.000MB -3.5%) vs baseline: +4.9%

✅ appsec-post

Time: ✅ 6.618ms (SLO: <6.750ms 🟡 -2.0%) vs baseline: -0.3%

Memory: ✅ 62.797MB (SLO: <65.000MB -3.4%) vs baseline: +4.8%

✅ appsec-telemetry

Time: ✅ 4.582ms (SLO: <4.750ms -3.5%) vs baseline: -0.7%

Memory: ✅ 62.718MB (SLO: <65.000MB -3.5%) vs baseline: +4.8%

✅ debugger

Time: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: +0.1%

Memory: ✅ 45.338MB (SLO: <47.000MB -3.5%) vs baseline: +4.6%

✅ iast-get

Time: ✅ 1.860ms (SLO: <2.000ms -7.0%) vs baseline: ~same

Memory: ✅ 42.349MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.8%

✅ profiler

Time: ✅ 1.914ms (SLO: <2.100ms -8.8%) vs baseline: +0.1%

Memory: ✅ 46.439MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.0%

✅ resource-renaming

Time: ✅ 3.369ms (SLO: <3.650ms -7.7%) vs baseline: -0.3%

Memory: ✅ 53.045MB (SLO: <53.500MB 🟡 -0.9%) vs baseline: +5.0%

✅ tracer

Time: ✅ 3.360ms (SLO: <3.650ms -7.9%) vs baseline: +0.1%

Memory: ✅ 53.045MB (SLO: <53.500MB 🟡 -0.9%) vs baseline: +4.9%

✅ tracer-native

Time: ✅ 3.360ms (SLO: <3.650ms -7.9%) vs baseline: ~same

Memory: ✅ 59.078MB (SLO: <60.000MB 🟡 -1.5%) vs baseline: +5.3%

🟡 flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 3.974ms (SLO: <4.200ms -5.4%) vs baseline: -0.3%

Memory: ✅ 62.993MB (SLO: <66.000MB -4.6%) vs baseline: +5.0%

✅ iast-enabled

Time: ✅ 2.445ms (SLO: <2.800ms 📉 -12.7%) vs baseline: -0.3%

Memory: ✅ 59.513MB (SLO: <60.000MB 🟡 -0.8%) vs baseline: +4.9%

✅ tracer-enabled

Time: ✅ 2.069ms (SLO: <2.250ms -8.1%) vs baseline: -0.3%

Memory: ✅ 52.947MB (SLO: <54.500MB -2.9%) vs baseline: +4.7%

🟡 packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 347.407ms (SLO: <354.300ms 🟡 -1.9%) vs baseline: +0.9%

Memory: ✅ 38.471MB (SLO: <40.000MB -3.8%) vs baseline: +7.5%

✅ cache_on

Time: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.6%

Memory: ✅ 36.994MB (SLO: <39.000MB -5.1%) vs baseline: +6.4%

⚠️ Unstable Tests (1 suite)
⚠️ coreapiscenario - 10/10 (1 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.299µs (SLO: <20.000µs 📉 -33.5%) vs baseline: +0.3%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ context_with_data_no_listeners

Time: ✅ 3.275µs (SLO: <10.000µs 📉 -67.3%) vs baseline: ~same

Memory: ✅ 32.086MB (SLO: <33.500MB -4.2%) vs baseline: +4.8%

✅ get_item_exists

Time: ✅ 0.585µs (SLO: <10.000µs 📉 -94.1%) vs baseline: +1.2%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.8%

✅ get_item_missing

Time: ✅ 0.639µs (SLO: <10.000µs 📉 -93.6%) vs baseline: +0.6%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ set_item

Time: ✅ 24.157µs (SLO: <30.000µs 📉 -19.5%) vs baseline: -0.7%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ All Tests Passing (16 suites)
✅ httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 83.898µs (SLO: <100.000µs 📉 -16.1%) vs baseline: +3.5%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ b3_headers

Time: ✅ 14.150µs (SLO: <20.000µs 📉 -29.2%) vs baseline: -0.4%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ b3_single_headers

Time: ✅ 13.358µs (SLO: <20.000µs 📉 -33.2%) vs baseline: +0.2%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 63.687µs (SLO: <80.000µs 📉 -20.4%) vs baseline: -0.4%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 65.952µs (SLO: <80.000µs 📉 -17.6%) vs baseline: +0.3%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ empty_headers

Time: ✅ 1.604µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.4%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.8%

✅ full_t_id_datadog_headers

Time: ✅ 22.921µs (SLO: <30.000µs 📉 -23.6%) vs baseline: -0.2%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ invalid_priority_header

Time: ✅ 6.601µs (SLO: <10.000µs 📉 -34.0%) vs baseline: +1.2%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ invalid_span_id_header

Time: ✅ 6.515µs (SLO: <10.000µs 📉 -34.8%) vs baseline: -0.1%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ invalid_tags_header

Time: ✅ 6.591µs (SLO: <10.000µs 📉 -34.1%) vs baseline: +1.4%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.9%

✅ invalid_trace_id_header

Time: ✅ 6.575µs (SLO: <10.000µs 📉 -34.2%) vs baseline: +0.7%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ large_header_no_matches

Time: ✅ 28.113µs (SLO: <30.000µs -6.3%) vs baseline: +0.3%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ large_valid_headers_all

Time: ✅ 29.149µs (SLO: <40.000µs 📉 -27.1%) vs baseline: +0.4%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ medium_header_no_matches

Time: ✅ 9.854µs (SLO: <20.000µs 📉 -50.7%) vs baseline: +0.3%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ medium_valid_headers_all

Time: ✅ 11.336µs (SLO: <20.000µs 📉 -43.3%) vs baseline: +1.3%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ none_propagation_style

Time: ✅ 1.715µs (SLO: <10.000µs 📉 -82.9%) vs baseline: +1.1%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ tracecontext_headers

Time: ✅ 35.004µs (SLO: <40.000µs 📉 -12.5%) vs baseline: +1.1%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ valid_headers_all

Time: ✅ 6.514µs (SLO: <10.000µs 📉 -34.9%) vs baseline: +0.5%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ valid_headers_basic

Time: ✅ 6.112µs (SLO: <10.000µs 📉 -38.9%) vs baseline: +0.3%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ wsgi_empty_headers

Time: ✅ 1.598µs (SLO: <10.000µs 📉 -84.0%) vs baseline: ~same

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ wsgi_invalid_priority_header

Time: ✅ 6.585µs (SLO: <10.000µs 📉 -34.1%) vs baseline: +1.0%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ wsgi_invalid_span_id_header

Time: ✅ 1.610µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +1.9%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ wsgi_invalid_tags_header

Time: ✅ 6.578µs (SLO: <10.000µs 📉 -34.2%) vs baseline: +0.6%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.8%

✅ wsgi_invalid_trace_id_header

Time: ✅ 6.540µs (SLO: <10.000µs 📉 -34.6%) vs baseline: -0.5%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ wsgi_large_header_no_matches

Time: ✅ 29.168µs (SLO: <40.000µs 📉 -27.1%) vs baseline: -0.1%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ wsgi_large_valid_headers_all

Time: ✅ 30.320µs (SLO: <40.000µs 📉 -24.2%) vs baseline: +0.5%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_medium_header_no_matches

Time: ✅ 10.253µs (SLO: <20.000µs 📉 -48.7%) vs baseline: +1.4%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ wsgi_medium_valid_headers_all

Time: ✅ 11.716µs (SLO: <20.000µs 📉 -41.4%) vs baseline: +1.5%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_valid_headers_all

Time: ✅ 6.534µs (SLO: <10.000µs 📉 -34.7%) vs baseline: -0.1%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ wsgi_valid_headers_basic

Time: ✅ 6.209µs (SLO: <10.000µs 📉 -37.9%) vs baseline: +1.7%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ httppropagationinject - 16/16

✅ ids_only

Time: ✅ 21.855µs (SLO: <30.000µs 📉 -27.1%) vs baseline: +0.6%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ with_all

Time: ✅ 29.190µs (SLO: <40.000µs 📉 -27.0%) vs baseline: +1.2%

Memory: ✅ 32.126MB (SLO: <33.500MB -4.1%) vs baseline: +4.6%

✅ with_dd_origin

Time: ✅ 25.496µs (SLO: <30.000µs 📉 -15.0%) vs baseline: +1.7%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.6%

✅ with_priority_and_origin

Time: ✅ 25.627µs (SLO: <40.000µs 📉 -35.9%) vs baseline: +4.0%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ with_sampling_priority

Time: ✅ 22.487µs (SLO: <30.000µs 📉 -25.0%) vs baseline: +4.1%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ with_tags

Time: ✅ 28.608µs (SLO: <40.000µs 📉 -28.5%) vs baseline: +5.8%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ with_tags_invalid

Time: ✅ 28.762µs (SLO: <40.000µs 📉 -28.1%) vs baseline: +1.5%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ with_tags_max_size

Time: ✅ 27.449µs (SLO: <40.000µs 📉 -31.4%) vs baseline: +0.3%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ iast_aspects - 40/40

✅ re_expand_aspect

Time: ✅ 31.687µs (SLO: <40.000µs 📉 -20.8%) vs baseline: -1.1%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ re_expand_noaspect

Time: ✅ 28.580µs (SLO: <40.000µs 📉 -28.5%) vs baseline: +0.6%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ re_findall_aspect

Time: ✅ 2.903µs (SLO: <10.000µs 📉 -71.0%) vs baseline: -0.3%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.1%

✅ re_findall_noaspect

Time: ✅ 1.420µs (SLO: <10.000µs 📉 -85.8%) vs baseline: ~same

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ re_finditer_aspect

Time: ✅ 4.419µs (SLO: <10.000µs 📉 -55.8%) vs baseline: ~same

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ re_finditer_noaspect

Time: ✅ 1.404µs (SLO: <10.000µs 📉 -86.0%) vs baseline: ~same

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ re_fullmatch_aspect

Time: ✅ 2.682µs (SLO: <10.000µs 📉 -73.2%) vs baseline: +1.0%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ re_fullmatch_noaspect

Time: ✅ 1.307µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +0.5%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ re_group_aspect

Time: ✅ 2.970µs (SLO: <10.000µs 📉 -70.3%) vs baseline: +1.8%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1%

✅ re_group_noaspect

Time: ✅ 1.631µs (SLO: <10.000µs 📉 -83.7%) vs baseline: -0.7%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ re_groups_aspect

Time: ✅ 3.076µs (SLO: <10.000µs 📉 -69.2%) vs baseline: -0.1%

Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0%

✅ re_groups_noaspect

Time: ✅ 1.696µs (SLO: <10.000µs 📉 -83.0%) vs baseline: -1.3%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ re_match_aspect

Time: ✅ 2.691µs (SLO: <10.000µs 📉 -73.1%) vs baseline: ~same

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.0%

✅ re_match_noaspect

Time: ✅ 1.295µs (SLO: <10.000µs 📉 -87.1%) vs baseline: -0.7%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ re_search_aspect

Time: ✅ 2.551µs (SLO: <10.000µs 📉 -74.5%) vs baseline: +0.6%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ re_search_noaspect

Time: ✅ 1.199µs (SLO: <10.000µs 📉 -88.0%) vs baseline: -0.2%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ re_sub_aspect

Time: ✅ 3.446µs (SLO: <10.000µs 📉 -65.5%) vs baseline: +2.0%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ re_sub_noaspect

Time: ✅ 1.552µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +1.3%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1%

✅ re_subn_aspect

Time: ✅ 3.685µs (SLO: <10.000µs 📉 -63.1%) vs baseline: -0.2%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ re_subn_noaspect

Time: ✅ 1.615µs (SLO: <10.000µs 📉 -83.9%) vs baseline: -0.3%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 4.241µs (SLO: <10.000µs 📉 -57.6%) vs baseline: +0.7%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ ospathbasename_noaspect

Time: ✅ 1.090µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +0.7%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.7%

✅ ospathjoin_aspect

Time: ✅ 6.153µs (SLO: <10.000µs 📉 -38.5%) vs baseline: +0.4%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ ospathjoin_noaspect

Time: ✅ 2.290µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.8%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ ospathnormcase_aspect

Time: ✅ 3.443µs (SLO: <10.000µs 📉 -65.6%) vs baseline: -1.4%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ ospathnormcase_noaspect

Time: ✅ 0.570µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.5%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ ospathsplit_aspect

Time: ✅ 4.805µs (SLO: <10.000µs 📉 -52.0%) vs baseline: +0.9%

Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0%

✅ ospathsplit_noaspect

Time: ✅ 1.595µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.1%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ ospathsplitdrive_aspect

Time: ✅ 3.626µs (SLO: <10.000µs 📉 -63.7%) vs baseline: -0.6%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ ospathsplitdrive_noaspect

Time: ✅ 0.700µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +1.1%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ ospathsplitext_aspect

Time: ✅ 4.548µs (SLO: <10.000µs 📉 -54.5%) vs baseline: +0.1%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ ospathsplitext_noaspect

Time: ✅ 1.383µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.3%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1%

✅ iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 1.446µs (SLO: <10.000µs 📉 -85.5%) vs baseline: ~same

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ rsplit_noaspect

Time: ✅ 0.585µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +0.7%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ split_aspect

Time: ✅ 1.414µs (SLO: <10.000µs 📉 -85.9%) vs baseline: +0.7%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ split_noaspect

Time: ✅ 0.573µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.7%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ splitlines_aspect

Time: ✅ 1.373µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.6%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ splitlines_noaspect

Time: ✅ 0.585µs (SLO: <10.000µs 📉 -94.1%) vs baseline: +0.2%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1%

✅ iastpropagation - 2/2

✅ no-propagation

Time: ✅ 48.713µs (SLO: <60.000µs 📉 -18.8%) vs baseline: -0.1%

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +4.9%

✅ otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.557ms (SLO: <42.000ms -3.4%) vs baseline: +0.4%

Memory: ✅ 34.623MB (SLO: <39.000MB 📉 -11.2%) vs baseline: +4.1%

✅ add-link

Time: ✅ 36.319ms (SLO: <38.550ms -5.8%) vs baseline: -0.2%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.1%

✅ add-metrics

Time: ✅ 219.316ms (SLO: <232.000ms -5.5%) vs baseline: ~same

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.7%

✅ add-tags

Time: ✅ 210.009ms (SLO: <221.600ms -5.2%) vs baseline: -0.5%

Memory: ✅ 34.465MB (SLO: <39.000MB 📉 -11.6%) vs baseline: +4.4%

✅ get-context

Time: ✅ 29.673ms (SLO: <31.300ms -5.2%) vs baseline: +2.3%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +4.9%

✅ is-recording

Time: ✅ 29.230ms (SLO: <31.000ms -5.7%) vs baseline: -0.2%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +5.1%

✅ record-exception

Time: ✅ 63.202ms (SLO: <65.850ms -4.0%) vs baseline: -0.1%

Memory: ✅ 34.505MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.1%

✅ set-status

Time: ✅ 31.844ms (SLO: <34.150ms -6.8%) vs baseline: -0.3%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +4.9%

✅ start

Time: ✅ 28.754ms (SLO: <30.150ms -4.6%) vs baseline: -0.1%

Memory: ✅ 34.505MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.7%

✅ start-finish

Time: ✅ 33.708ms (SLO: <35.350ms -4.6%) vs baseline: -0.2%

Memory: ✅ 34.465MB (SLO: <39.000MB 📉 -11.6%) vs baseline: +4.7%

✅ start-finish-telemetry

Time: ✅ 33.892ms (SLO: <35.450ms -4.4%) vs baseline: +0.1%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.3%

✅ update-name

Time: ✅ 31.033ms (SLO: <33.400ms -7.1%) vs baseline: +0.4%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +4.9%

✅ otelspan - 22/22

✅ add-event

Time: ✅ 40.804ms (SLO: <47.150ms 📉 -13.5%) vs baseline: +1.3%

Memory: ✅ 43.629MB (SLO: <47.000MB -7.2%) vs baseline: +4.6%

✅ add-metrics

Time: ✅ 316.644ms (SLO: <344.800ms -8.2%) vs baseline: +0.2%

Memory: ✅ 651.665MB (SLO: <675.000MB -3.5%) vs baseline: +4.6%

✅ add-tags

Time: ✅ 287.008ms (SLO: <314.000ms -8.6%) vs baseline: -0.8%

Memory: ✅ 653.099MB (SLO: <675.000MB -3.2%) vs baseline: +4.9%

✅ get-context

Time: ✅ 80.275ms (SLO: <92.350ms 📉 -13.1%) vs baseline: +0.4%

Memory: ✅ 39.652MB (SLO: <46.500MB 📉 -14.7%) vs baseline: +4.9%

✅ is-recording

Time: ✅ 37.868ms (SLO: <44.500ms 📉 -14.9%) vs baseline: ~same

Memory: ✅ 43.161MB (SLO: <47.500MB -9.1%) vs baseline: +4.9%

✅ record-exception

Time: ✅ 57.961ms (SLO: <67.650ms 📉 -14.3%) vs baseline: -0.3%

Memory: ✅ 39.865MB (SLO: <47.000MB 📉 -15.2%) vs baseline: +4.8%

✅ set-status

Time: ✅ 43.882ms (SLO: <50.400ms 📉 -12.9%) vs baseline: +0.4%

Memory: ✅ 43.107MB (SLO: <47.000MB -8.3%) vs baseline: +4.6%

✅ start

Time: ✅ 37.278ms (SLO: <43.450ms 📉 -14.2%) vs baseline: +0.2%

Memory: ✅ 43.127MB (SLO: <47.000MB -8.2%) vs baseline: +4.8%

✅ start-finish

Time: ✅ 82.720ms (SLO: <88.000ms -6.0%) vs baseline: +1.6%

Memory: ✅ 34.623MB (SLO: <46.500MB 📉 -25.5%) vs baseline: +5.0%

✅ start-finish-telemetry

Time: ✅ 84.841ms (SLO: <89.000ms -4.7%) vs baseline: +2.2%

Memory: ✅ 34.524MB (SLO: <46.500MB 📉 -25.8%) vs baseline: +4.9%

✅ update-name

Time: ✅ 38.717ms (SLO: <45.150ms 📉 -14.2%) vs baseline: -0.2%

Memory: ✅ 43.454MB (SLO: <47.000MB -7.5%) vs baseline: +4.9%

✅ packagesupdateimporteddependencies - 24/24

✅ import_many

Time: ✅ 156.132µs (SLO: <170.000µs -8.2%) vs baseline: +0.4%

Memory: ✅ 37.476MB (SLO: <38.500MB -2.7%) vs baseline: +5.0%

✅ import_many_cached

Time: ✅ 121.046µs (SLO: <130.000µs -6.9%) vs baseline: -0.5%

Memory: ✅ 37.343MB (SLO: <38.500MB -3.0%) vs baseline: +4.9%

✅ import_many_stdlib

Time: ✅ 1.618ms (SLO: <1.750ms -7.6%) vs baseline: ~same

Memory: ✅ 37.262MB (SLO: <38.500MB -3.2%) vs baseline: +4.1%

✅ import_many_stdlib_cached

Time: ✅ 0.978ms (SLO: <1.100ms 📉 -11.1%) vs baseline: +0.1%

Memory: ✅ 37.529MB (SLO: <38.500MB -2.5%) vs baseline: +4.8%

✅ import_many_unknown

Time: ✅ 833.135µs (SLO: <890.000µs -6.4%) vs baseline: ~same

Memory: ✅ 37.469MB (SLO: <38.500MB -2.7%) vs baseline: +5.6%

✅ import_many_unknown_cached

Time: ✅ 798.083µs (SLO: <870.000µs -8.3%) vs baseline: +1.2%

Memory: ✅ 37.546MB (SLO: <38.500MB -2.5%) vs baseline: +5.5%

✅ import_one

Time: ✅ 19.922µs (SLO: <30.000µs 📉 -33.6%) vs baseline: +0.3%

Memory: ✅ 36.999MB (SLO: <39.000MB -5.1%) vs baseline: +4.2%

✅ import_one_cache

Time: ✅ 6.259µs (SLO: <10.000µs 📉 -37.4%) vs baseline: ~same

Memory: ✅ 37.235MB (SLO: <38.500MB -3.3%) vs baseline: +4.8%

✅ import_one_stdlib

Time: ✅ 18.873µs (SLO: <20.000µs -5.6%) vs baseline: +0.3%

Memory: ✅ 37.258MB (SLO: <38.500MB -3.2%) vs baseline: +4.8%

✅ import_one_stdlib_cache

Time: ✅ 6.302µs (SLO: <10.000µs 📉 -37.0%) vs baseline: +0.4%

Memory: ✅ 37.008MB (SLO: <38.500MB -3.9%) vs baseline: +4.0%

✅ import_one_unknown

Time: ✅ 45.455µs (SLO: <50.000µs -9.1%) vs baseline: ~same

Memory: ✅ 37.376MB (SLO: <38.500MB -2.9%) vs baseline: +5.1%

✅ import_one_unknown_cache

Time: ✅ 6.331µs (SLO: <10.000µs 📉 -36.7%) vs baseline: +1.0%

Memory: ✅ 37.059MB (SLO: <38.500MB -3.7%) vs baseline: +4.0%

✅ ratelimiter - 12/12

✅ defaults

Time: ✅ 2.358µs (SLO: <10.000µs 📉 -76.4%) vs baseline: ~same

Memory: ✅ 31.752MB (SLO: <34.000MB -6.6%) vs baseline: +4.9%

✅ high_rate_limit

Time: ✅ 2.396µs (SLO: <10.000µs 📉 -76.0%) vs baseline: -1.3%

Memory: ✅ 31.772MB (SLO: <34.000MB -6.6%) vs baseline: +4.7%

✅ long_window

Time: ✅ 2.340µs (SLO: <10.000µs 📉 -76.6%) vs baseline: -1.7%

Memory: ✅ 31.772MB (SLO: <34.000MB -6.6%) vs baseline: +5.0%

✅ low_rate_limit

Time: ✅ 2.347µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -1.1%

Memory: ✅ 31.831MB (SLO: <34.000MB -6.4%) vs baseline: +5.1%

✅ no_rate_limit

Time: ✅ 0.824µs (SLO: <10.000µs 📉 -91.8%) vs baseline: -0.4%

Memory: ✅ 31.772MB (SLO: <34.000MB -6.6%) vs baseline: +5.0%

✅ short_window

Time: ✅ 2.478µs (SLO: <10.000µs 📉 -75.2%) vs baseline: -1.3%

Memory: ✅ 31.713MB (SLO: <34.000MB -6.7%) vs baseline: +4.7%

✅ recursivecomputation - 8/8

✅ deep

Time: ✅ 309.425ms (SLO: <320.950ms -3.6%) vs baseline: ~same

Memory: ✅ 32.853MB (SLO: <34.500MB -4.8%) vs baseline: +4.4%

✅ deep-profiled

Time: ✅ 326.904ms (SLO: <359.150ms -9.0%) vs baseline: -0.5%

Memory: ✅ 37.339MB (SLO: <39.000MB -4.3%) vs baseline: +4.9%

✅ medium

Time: ✅ 7.047ms (SLO: <7.400ms -4.8%) vs baseline: +0.3%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1%

✅ shallow

Time: ✅ 0.946ms (SLO: <1.050ms -9.9%) vs baseline: ~same

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9%

✅ samplingrules - 8/8

✅ average_match

Time: ✅ 138.488µs (SLO: <290.000µs 📉 -52.2%) vs baseline: +1.0%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.5%

✅ high_match

Time: ✅ 173.149µs (SLO: <480.000µs 📉 -63.9%) vs baseline: -0.4%

Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.8%

✅ low_match

Time: ✅ 99.706µs (SLO: <120.000µs 📉 -16.9%) vs baseline: ~same

Memory: ✅ 600.829MB (SLO: <700.000MB 📉 -14.2%) vs baseline: +4.8%

✅ very_low_match

Time: ✅ 2.653ms (SLO: <8.500ms 📉 -68.8%) vs baseline: -1.2%

Memory: ✅ 68.339MB (SLO: <75.000MB -8.9%) vs baseline: +4.9%

✅ sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.493µs (SLO: <20.000µs 📉 -47.5%) vs baseline: -0.5%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +5.0%

✅ all-enabled

Time: ✅ 39.988µs (SLO: <50.000µs 📉 -20.0%) vs baseline: -0.4%

Memory: ✅ 32.539MB (SLO: <34.000MB -4.3%) vs baseline: +4.6%

✅ collectipvariant_exists

Time: ✅ 40.607µs (SLO: <50.000µs 📉 -18.8%) vs baseline: -0.7%

Memory: ✅ 32.558MB (SLO: <34.000MB -4.2%) vs baseline: +4.7%

✅ no-collectipvariant

Time: ✅ 39.988µs (SLO: <50.000µs 📉 -20.0%) vs baseline: -0.9%

Memory: ✅ 32.519MB (SLO: <34.000MB -4.4%) vs baseline: +4.7%

✅ no-useragentvariant

Time: ✅ 38.647µs (SLO: <50.000µs 📉 -22.7%) vs baseline: -0.5%

Memory: ✅ 32.499MB (SLO: <34.000MB -4.4%) vs baseline: +4.8%

✅ obfuscation-no-query

Time: ✅ 40.528µs (SLO: <50.000µs 📉 -18.9%) vs baseline: -0.8%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +5.1%

✅ obfuscation-regular-case-explicit-query

Time: ✅ 75.894µs (SLO: <90.000µs 📉 -15.7%) vs baseline: ~same

Memory: ✅ 32.952MB (SLO: <34.000MB -3.1%) vs baseline: +4.7%

✅ obfuscation-regular-case-implicit-query

Time: ✅ 76.484µs (SLO: <90.000µs 📉 -15.0%) vs baseline: ~same

Memory: ✅ 32.912MB (SLO: <34.000MB -3.2%) vs baseline: +4.8%

✅ obfuscation-send-querystring-disabled

Time: ✅ 154.232µs (SLO: <170.000µs -9.3%) vs baseline: ~same

Memory: ✅ 32.952MB (SLO: <34.500MB -4.5%) vs baseline: +4.7%

✅ obfuscation-worst-case-explicit-query

Time: ✅ 148.377µs (SLO: <160.000µs -7.3%) vs baseline: +0.3%

Memory: ✅ 32.971MB (SLO: <34.500MB -4.4%) vs baseline: +4.9%

✅ obfuscation-worst-case-implicit-query

Time: ✅ 154.724µs (SLO: <170.000µs -9.0%) vs baseline: ~same

Memory: ✅ 33.010MB (SLO: <34.500MB -4.3%) vs baseline: +5.1%

✅ useragentvariant_exists_1

Time: ✅ 39.445µs (SLO: <50.000µs 📉 -21.1%) vs baseline: -0.2%

Memory: ✅ 32.558MB (SLO: <34.000MB -4.2%) vs baseline: +4.8%

✅ useragentvariant_exists_2

Time: ✅ 40.525µs (SLO: <50.000µs 📉 -18.9%) vs baseline: -0.4%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +5.0%

✅ useragentvariant_exists_3

Time: ✅ 39.999µs (SLO: <50.000µs 📉 -20.0%) vs baseline: +0.2%

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +4.9%

✅ useragentvariant_not_exists_1

Time: ✅ 39.601µs (SLO: <50.000µs 📉 -20.8%) vs baseline: ~same

Memory: ✅ 32.617MB (SLO: <34.000MB -4.1%) vs baseline: +4.9%

✅ useragentvariant_not_exists_2

Time: ✅ 39.386µs (SLO: <50.000µs 📉 -21.2%) vs baseline: -0.8%

Memory: ✅ 32.558MB (SLO: <34.000MB -4.2%) vs baseline: +4.7%

✅ span - 26/26

✅ add-event

Time: ✅ 20.454ms (SLO: <22.500ms -9.1%) vs baseline: +2.1%

Memory: ✅ 48.779MB (SLO: <53.000MB -8.0%) vs baseline: +4.9%

✅ add-metrics

Time: ✅ 89.761ms (SLO: <93.500ms -4.0%) vs baseline: +0.4%

Memory: ✅ 735.578MB (SLO: <961.000MB 📉 -23.5%) vs baseline: +4.8%

✅ add-tags

Time: ✅ 146.407ms (SLO: <155.000ms -5.5%) vs baseline: +0.5%

Memory: ✅ 735.787MB (SLO: <962.500MB 📉 -23.6%) vs baseline: +4.8%

✅ get-context

Time: ✅ 18.562ms (SLO: <20.500ms -9.5%) vs baseline: +0.9%

Memory: ✅ 47.547MB (SLO: <53.000MB 📉 -10.3%) vs baseline: +4.7%

✅ is-recording

Time: ✅ 18.599ms (SLO: <20.500ms -9.3%) vs baseline: -0.1%

Memory: ✅ 47.577MB (SLO: <53.000MB 📉 -10.2%) vs baseline: +4.8%

✅ record-exception

Time: ✅ 37.494ms (SLO: <40.000ms -6.3%) vs baseline: -0.3%

Memory: ✅ 42.051MB (SLO: <53.000MB 📉 -20.7%) vs baseline: +4.8%

✅ set-status

Time: ✅ 20.842ms (SLO: <22.000ms -5.3%) vs baseline: +2.8%

Memory: ✅ 47.627MB (SLO: <53.000MB 📉 -10.1%) vs baseline: +4.9%

✅ start

Time: ✅ 18.149ms (SLO: <20.500ms 📉 -11.5%) vs baseline: -0.2%

Memory: ✅ 47.523MB (SLO: <53.000MB 📉 -10.3%) vs baseline: +4.6%

✅ start-finish

Time: ✅ 50.519ms (SLO: <52.500ms -3.8%) vs baseline: -0.6%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9%

✅ start-finish-telemetry

Time: ✅ 51.972ms (SLO: <54.500ms -4.6%) vs baseline: ~same

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ start-finish-traceid128

Time: ✅ 53.758ms (SLO: <57.000ms -5.7%) vs baseline: -1.4%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ start-traceid128

Time: ✅ 18.459ms (SLO: <22.500ms 📉 -18.0%) vs baseline: +0.2%

Memory: ✅ 47.622MB (SLO: <53.000MB 📉 -10.1%) vs baseline: +5.0%

✅ update-name

Time: ✅ 18.751ms (SLO: <22.000ms 📉 -14.8%) vs baseline: +0.6%

Memory: ✅ 48.152MB (SLO: <53.000MB -9.1%) vs baseline: +4.5%

✅ telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 3.012µs (SLO: <20.000µs 📉 -84.9%) vs baseline: +1.3%

Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.2%

✅ 1-count-metrics-100-times

Time: ✅ 200.502µs (SLO: <220.000µs -8.9%) vs baseline: +0.5%

Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9%

✅ 1-distribution-metric-1-times

Time: ✅ 3.291µs (SLO: <20.000µs 📉 -83.5%) vs baseline: ~same

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.5%

✅ 1-distribution-metrics-100-times

Time: ✅ 213.691µs (SLO: <220.000µs -2.9%) vs baseline: +0.4%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7%

✅ 1-gauge-metric-1-times

Time: ✅ 2.149µs (SLO: <20.000µs 📉 -89.3%) vs baseline: -1.9%

Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9%

✅ 1-gauge-metrics-100-times

Time: ✅ 137.246µs (SLO: <150.000µs -8.5%) vs baseline: -0.6%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.8%

✅ 1-rate-metric-1-times

Time: ✅ 3.084µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -1.0%

Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9%

✅ 1-rate-metrics-100-times

Time: ✅ 213.079µs (SLO: <250.000µs 📉 -14.8%) vs baseline: +0.2%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9%

✅ 100-count-metrics-100-times

Time: ✅ 20.171ms (SLO: <22.000ms -8.3%) vs baseline: -0.5%

Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +4.9%

✅ 100-distribution-metrics-100-times

Time: ✅ 2.224ms (SLO: <2.300ms -3.3%) vs baseline: -1.2%

Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.7%

✅ 100-gauge-metrics-100-times

Time: ✅ 1.417ms (SLO: <1.550ms -8.6%) vs baseline: +0.5%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9%

✅ 100-rate-metrics-100-times

Time: ✅ 2.203ms (SLO: <2.550ms 📉 -13.6%) vs baseline: +0.2%

Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +4.9%

✅ flush-1-metric

Time: ✅ 4.711µs (SLO: <20.000µs 📉 -76.4%) vs baseline: +1.4%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.7%

✅ flush-100-metrics

Time: ✅ 174.409µs (SLO: <250.000µs 📉 -30.2%) vs baseline: +0.2%

Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.2%

✅ flush-1000-metrics

Time: ✅ 2.127ms (SLO: <2.500ms 📉 -14.9%) vs baseline: -0.6%

Memory: ✅ 32.991MB (SLO: <34.500MB -4.4%) vs baseline: +5.0%

✅ tracer - 6/6

✅ large

Time: ✅ 29.623ms (SLO: <32.950ms 📉 -10.1%) vs baseline: +1.0%

Memory: ✅ 33.286MB (SLO: <34.500MB -3.5%) vs baseline: +5.1%

✅ medium

Time: ✅ 2.938ms (SLO: <3.200ms -8.2%) vs baseline: +0.3%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9%

✅ small

Time: ✅ 330.384µs (SLO: <370.000µs 📉 -10.7%) vs baseline: +0.3%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.8%

ℹ️ Scenarios Missing SLO Configuration (9 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

  • coreapiscenario-core_dispatch_listeners
  • coreapiscenario-core_dispatch_no_listeners
  • coreapiscenario-core_dispatch_with_results_listeners
  • coreapiscenario-core_dispatch_with_results_no_listeners
  • djangosimple-baseline
  • errortrackingdjangosimple-baseline
  • errortrackingflasksqli-baseline
  • flasksimple-baseline
  • flasksqli-baseline

@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 28, 2025
@taegyunkim taegyunkim changed the title fix(profiling): increase ref before stealing chore(profiling): increase ref before stealing Oct 28, 2025
@taegyunkim taegyunkim added the Profiling Continous Profling label Oct 28, 2025
@taegyunkim taegyunkim marked this pull request as ready for review October 28, 2025 17:17
@taegyunkim taegyunkim requested a review from a team as a code owner October 28, 2025 17:17
nsrip-dd
nsrip-dd approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack/in person, it's not clear to me if this will fix crashes but it makes sense to me to write the code this way regardless. If it does fix crashes, that'd be very interesting!

@taegyunkim
Copy link
Contributor Author

Thanks for reviewing!

As discussed on Slack/in person, it's not clear to me if this will fix crashes but it makes sense to me to write the code this way regardless. If it does fix crashes, that'd be very interesting!

Yeah after reading the CPython docs, I gained more confidence that it should have been written this way from the beginning. Especially, this

When you want to keep using an object although the reference to it will be stolen, use Py_INCREF() to grab another reference before calling the reference-stealing function.

@taegyunkim taegyunkim enabled auto-merge (squash) October 28, 2025 17:30
@taegyunkim taegyunkim merged commit fe38106 into main Oct 28, 2025
515 of 517 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/tuple-incref branch October 28, 2025 18:09
taegyunkim added a commit that referenced this pull request Oct 28, 2025
@taegyunkim
chore(profiling): increase ref before stealing (#15031)
3246bd1 
## Description

Noticed this while looking into crashes related to the memory profiler.
[See notebook
here](https://app.datadoghq.com/notebook/13359436/memory-profiler-crashes).
We are not sure whether this would be root cause of such crashes, but
still think it's 'logically' correct to increment the reference before
calling `PyTuple_SET_ITEM()`.

When you call `PyTuple_SET_ITEM(p, pos, obj);`, then the ownership of
the object `o` is transferred to the tuple.

- https://docs.python.org/3/c-api/tuple.html#c.PyTuple_SET_ITEM
- https://docs.python.org/3/c-api/intro.html#reference-count-details

> Stealing a reference means that when you pass a reference to a
function, that function assumes that it now owns that reference, and you
are not responsible for it any longer

> When you want to keep using an object although the reference to it
will be stolen, use
[Py_INCREF()](https://docs.python.org/3/c-api/refcounting.html#c.Py_INCREF)
to grab another reference before calling the reference-stealing
function.


<!-- Provide an overview of the change and motivation for the change -->

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks
-->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsrip-dd nsrip-dd nsrip-dd approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taegyunkim @nsrip-dd