- 
                Notifications
    You must be signed in to change notification settings 
- Fork 468
chore(logger): disable native logging by default #15005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 
  | 
| Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 247 ± 5 ms. The average import time from base is: 251 ± 5 ms. The import time difference between this PR and base is: -4.2 ± 0.2 ms. Import time breakdownThe following import paths have shrunk: 
             | 
| Performance SLOsComparing candidate vianney/disable-native-logging-by-default (542214b) with baseline main (d5872b9) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.256µs (SLO: <10.000µs 📉 -57.4%) vs baseline: +0.3% Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.3% ✅ ospathbasename_noaspectTime: ✅ 1.082µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.4% Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.3% ✅ ospathjoin_aspectTime: ✅ 6.168µs (SLO: <10.000µs 📉 -38.3%) vs baseline: -0.3% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.1% ✅ ospathjoin_noaspectTime: ✅ 2.289µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.1% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +4.4% ✅ ospathnormcase_aspectTime: ✅ 4.067µs (SLO: <10.000µs 📉 -59.3%) vs baseline: 📈 +17.8% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.2% ✅ ospathnormcase_noaspectTime: ✅ 0.565µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.9% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.0% ✅ ospathsplit_aspectTime: ✅ 4.878µs (SLO: <10.000µs 📉 -51.2%) vs baseline: +1.3% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.1% ✅ ospathsplit_noaspectTime: ✅ 1.586µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -1.0% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.1% ✅ ospathsplitdrive_aspectTime: ✅ 3.734µs (SLO: <10.000µs 📉 -62.7%) vs baseline: +1.9% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.2% ✅ ospathsplitdrive_noaspectTime: ✅ 0.687µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -1.8% Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.4% ✅ ospathsplitext_aspectTime: ✅ 5.452µs (SLO: <10.000µs 📉 -45.5%) vs baseline: 📈 +20.6% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.2% ✅ ospathsplitext_noaspectTime: ✅ 1.379µs (SLO: <10.000µs 📉 -86.2%) vs baseline: ~same Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +4.6% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.419ms (SLO: <22.300ms -8.4%) vs baseline: -0.3% Memory: ✅ 66.078MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ exception-replay-enabledTime: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: -0.2% Memory: ✅ 64.154MB (SLO: <67.000MB -4.2%) vs baseline: +4.6% ✅ iastTime: ✅ 20.441ms (SLO: <22.250ms -8.1%) vs baseline: -0.1% Memory: ✅ 66.025MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.566ms (SLO: <16.550ms -5.9%) vs baseline: +0.6% Memory: ✅ 53.757MB (SLO: <54.500MB 🟡 -1.4%) vs baseline: +4.3% ✅ resource-renamingTime: ✅ 20.548ms (SLO: <21.750ms -5.5%) vs baseline: -0.2% Memory: ✅ 66.100MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 25.487ms (SLO: <28.200ms -9.6%) vs baseline: +0.2% Memory: ✅ 67.342MB (SLO: <69.500MB -3.1%) vs baseline: +4.0% ✅ tracerTime: ✅ 20.451ms (SLO: <21.750ms -6.0%) vs baseline: -0.2% Memory: ✅ 66.139MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ tracer-and-profilerTime: ✅ 22.668ms (SLO: <23.500ms -3.5%) vs baseline: ~same Memory: ✅ 67.293MB (SLO: <68.000MB 🟡 -1.0%) vs baseline: +4.6% ✅ tracer-dont-create-db-spansTime: ✅ 19.275ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.6% Memory: ✅ 66.064MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.632ms (SLO: <17.500ms -5.0%) vs baseline: -0.3% Memory: ✅ 65.687MB (SLO: <67.000MB 🟡 -2.0%) vs baseline: +4.6% ✅ tracer-nativeTime: ✅ 20.464ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 67.260MB (SLO: <72.500MB -7.2%) vs baseline: -1.6% ✅ tracer-no-cachesTime: ✅ 18.411ms (SLO: <19.650ms -6.3%) vs baseline: -0.2% Memory: ✅ 65.952MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.752ms (SLO: <20.100ms -6.7%) vs baseline: ~same Memory: ✅ 65.672MB (SLO: <67.000MB 🟡 -2.0%) vs baseline: +4.5% ✅ tracer-no-middlewareTime: ✅ 20.164ms (SLO: <21.500ms -6.2%) vs baseline: +0.2% Memory: ✅ 66.070MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.285ms (SLO: <22.000ms -7.8%) vs baseline: -0.1% Memory: ✅ 66.080MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.022ms (SLO: <19.850ms -9.2%) vs baseline: -0.7% Memory: ✅ 65.697MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.4% ✅ errortracking-enabled-userTime: ✅ 18.112ms (SLO: <19.400ms -6.6%) vs baseline: +0.4% Memory: ✅ 65.716MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.5% ✅ tracer-enabledTime: ✅ 18.137ms (SLO: <19.450ms -6.7%) vs baseline: +0.4% Memory: ✅ 65.618MB (SLO: <66.500MB 🟡 -1.3%) vs baseline: +4.5% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: -0.5% Memory: ✅ 62.294MB (SLO: <65.000MB -4.2%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.606ms (SLO: <6.750ms -2.1%) vs baseline: -0.4% Memory: ✅ 62.351MB (SLO: <65.000MB -4.1%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.583ms (SLO: <4.750ms -3.5%) vs baseline: -0.7% Memory: ✅ 62.249MB (SLO: <65.000MB -4.2%) vs baseline: +4.6% ✅ debuggerTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: -0.3% Memory: ✅ 45.185MB (SLO: <47.000MB -3.9%) vs baseline: +4.6% ✅ iast-getTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: -0.7% Memory: ✅ 42.093MB (SLO: <49.000MB 📉 -14.1%) vs baseline: +4.2% ✅ profilerTime: ✅ 1.917ms (SLO: <2.100ms -8.7%) vs baseline: -0.3% Memory: ✅ 46.169MB (SLO: <47.000MB 🟡 -1.8%) vs baseline: +4.4% ✅ resource-renamingTime: ✅ 3.363ms (SLO: <3.650ms -7.9%) vs baseline: -0.4% Memory: ✅ 52.516MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.5% ✅ tracerTime: ✅ 3.361ms (SLO: <3.650ms -7.9%) vs baseline: +0.2% Memory: ✅ 52.602MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.6% ✅ tracer-nativeTime: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: +0.3% Memory: ✅ 54.093MB (SLO: <60.000MB -9.8%) vs baseline: -2.6% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.977ms (SLO: <4.200ms -5.3%) vs baseline: ~same Memory: ✅ 62.285MB (SLO: <66.000MB -5.6%) vs baseline: +4.7% ✅ iast-enabledTime: ✅ 2.442ms (SLO: <2.800ms 📉 -12.8%) vs baseline: -0.2% Memory: ✅ 59.041MB (SLO: <60.000MB 🟡 -1.6%) vs baseline: +4.6% ✅ tracer-enabledTime: ✅ 2.060ms (SLO: <2.250ms -8.4%) vs baseline: ~same Memory: ✅ 52.534MB (SLO: <54.500MB -3.6%) vs baseline: +4.6% 
 | 
| test change? | 
c6c7d75    to
    542214b      
    Compare
  
    
Description
Disable native logging by default as it shouldn't be logging to file by default.
Testing
Risks
Additional Notes