Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): fix tz warning #11497

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(tests): fix tz warning #11497

wants to merge 3 commits into from

Conversation

Kyle-Verhoog
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog commented Nov 21, 2024

Running the tests locally, I get:

DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC

The recommended upgrade is to use datetime.now(timezone.utc) which is what is done here.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@Kyle-Verhoog Kyle-Verhoog requested a review from a team as a code owner November 21, 2024 23:22
@Kyle-Verhoog Kyle-Verhoog added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 21, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/utils.py                                                          @DataDog/python-guild

Running the tests locally, I get:

```
DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC
```

The recommended upgrade is to use `datetime.now(timezone.utc)` which is
what is done here.
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 21, 2024

Datadog Report

Branch report: kylev/fix-tz-warning
Commit report: 2e83161
Test service: dd-trace-py

✅ 0 Failed, 918 Passed, 550 Skipped, 13m 13.37s Total duration (23m 10.84s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 22, 2024

Benchmarks

Benchmark execution time: 2024-11-22 22:51:08

Comparing candidate commit 2e83161 in PR branch kylev/fix-tz-warning with baseline commit defea4e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 264 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants