Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asm): standalone missing tag [backport 2.14] #11486

Open
wants to merge 1 commit into
base: 2.14
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Backport 832301c from #11452 to 2.14.

This fix resolves a possibly missing ASM standalone tag on root spans.
It was only detected previously on uwsgi on nightly system tests.

  • ensure that all root spans are tagged.

APPSEC-55222

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

This fix resolves a possibly missing ASM standalone tag on root spans.
It was only detected previously on uwsgi on nightly system tests.
- ensure that all root spans are tagged.

APPSEC-55222

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 832301c)
@github-actions github-actions bot requested a review from a team as a code owner November 21, 2024 16:05
@github-actions github-actions bot added bug ASM Application Security Monitoring labels Nov 21, 2024
@github-actions github-actions bot requested a review from a team as a code owner November 21, 2024 16:05
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-11452-to-2.14
Commit report: 3ec8b91
Test service: dd-trace-py

✅ 0 Failed, 1107 Passed, 179 Skipped, 29m 10.37s Total duration (7m 28.42s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks

Benchmark execution time: 2024-11-21 16:49:43

Comparing candidate commit 3ec8b91 in PR branch backport-11452-to-2.14 with baseline commit bb5ec76 in branch 2.14.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 356 metrics, 48 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant