Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracing): fix some service naming tests that were failing silently #11483

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Nov 21, 2024

Motivation

These tests were failing silently, I would assume due to CI-Vis possibly suppressing errors. See silent failures here.

DOES NOT NEED TO BE BACKPORTED

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Nov 21, 2024

CODEOWNERS have been resolved as:

ddtrace/contrib/internal/bottle/trace.py                                @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/botocore/test.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python

@wconti27 wconti27 changed the title Conti/update service naming algo chore(tracing): fix some service naming tests that were failing silently Nov 21, 2024
@wconti27 wconti27 self-assigned this Nov 21, 2024
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: conti/update-service-naming-algo
Commit report: 1844a4e
Test service: dd-trace-py

✅ 0 Failed, 10 Passed, 1368 Skipped, 55.92s Total duration (35m 13.04s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks

Benchmark execution time: 2024-11-21 15:57:40

Comparing candidate commit 1844a4e in PR branch conti/update-service-naming-algo with baseline commit 83ded13 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 372 metrics, 2 unstable metrics.

@wconti27 wconti27 added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 21, 2024
@wconti27
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 21, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-21 16:09:29 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2024-11-21 17:27:29 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit 3f108e5:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.

@erikayasuda
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 21, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-21 22:28:46 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-11-21 22:55:29 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit 25ca482:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants