Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci_visibility): reset tmppath_result_key fixture if need be #11480

Merged

Conversation

romainkomorndatadog
Copy link
Collaborator

@romainkomorndatadog romainkomorndatadog commented Nov 21, 2024

In versions > 7.4 of pytest, the tmppath_result_key key may be stashed on items, which means it needs to be reinstantiated if we retry it.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/contrib/pytest/_retry_utils.py                                  @DataDog/ci-app-libraries
ddtrace/contrib/pytest/_types.py                                        @DataDog/ci-app-libraries

@romainkomorndatadog romainkomorndatadog added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 21, 2024
@romainkomorndatadog romainkomorndatadog marked this pull request as ready for review November 22, 2024 10:44
@romainkomorndatadog romainkomorndatadog requested a review from a team as a code owner November 22, 2024 10:44
@romainkomorndatadog
Copy link
Collaborator Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 22, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-22 11:03:42 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-22 11:12:52 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 34m.


2024-11-22 11:44:39 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit eea27c1:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants