-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: explicitly set resource request/limits for test job #11476
base: main
Are you sure you want to change the base?
Conversation
|
BenchmarksBenchmark execution time: 2024-11-21 04:36:04 Comparing candidate commit 059f0ae in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics. |
@@ -13,6 +13,11 @@ variables: | |||
# DEV: we have a larger pool of amd64 runners, prefer that over arm64 | |||
tags: [ "arch:amd64" ] | |||
timeout: 20m | |||
variables: | |||
KUBERNETES_CPU_REQUEST: 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be better to have a lower request than limit?
most of our jobs aren't going to use 12 CPUs anyways, majority of them are single threaded.
better to have request 1/2 and limit of 12?
same with memory, request of 3/4 and limit of 16?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, based on how the limits are enforced, requests must equal the limit.
I still wonder if this is too aggressive to apply to all of our testrunner jobs, should we be more targeted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applying this in a more targeted manner would help reduce resource waste.
Checklist
Reviewer Checklist