Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: explicitly set resource request/limits for test job #11476

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Nov 20, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python

@taegyunkim taegyunkim changed the title ci: explicitly set resource limits ci: explicitly set resource request/limits for test job Nov 20, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2024

Benchmarks

Benchmark execution time: 2024-11-21 04:36:04

Comparing candidate commit 059f0ae in PR branch taegyunkim/ci-resource-limits with baseline commit d5ac5f9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

@taegyunkim taegyunkim added changelog/no-changelog A changelog entry is not required for this PR. CI labels Nov 21, 2024
@@ -13,6 +13,11 @@ variables:
# DEV: we have a larger pool of amd64 runners, prefer that over arm64
tags: [ "arch:amd64" ]
timeout: 20m
variables:
KUBERNETES_CPU_REQUEST: 12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to have a lower request than limit?

most of our jobs aren't going to use 12 CPUs anyways, majority of them are single threaded.

better to have request 1/2 and limit of 12?

same with memory, request of 3/4 and limit of 16?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, based on how the limits are enforced, requests must equal the limit.

I still wonder if this is too aggressive to apply to all of our testrunner jobs, should we be more targeted?

Copy link
Collaborator

@emmettbutler emmettbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying this in a more targeted manner would help reduce resource waste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants