Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): turn off dogweb CI runs [backport 2.17] #11467

Open
wants to merge 1 commit into
base: 2.17
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Backport d45dd33 from #11414 to 2.17.

This change disables dogfooding CI runs triggered from this repo, because they currently cost more than the benefit they provide.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

This change disables dogfooding CI runs triggered from this repo,
because they currently cost more than the benefit they provide.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit d45dd33)
@github-actions github-actions bot requested review from a team as code owners November 20, 2024 17:43
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 20, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2024

Benchmarks

Benchmark execution time: 2024-11-20 18:29:15

Comparing candidate commit 186385d in PR branch backport-11414-to-2.17 with baseline commit 41e9e16 in branch 2.17.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 383 metrics, 2 unstable metrics.

scenario:iast_aspects-format_map_aspect

  • 🟥 execution_time [+490.440ns; +546.752ns] or [+9.208%; +10.265%]

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+633.746ns; +691.575ns] or [+17.194%; +18.763%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+389.442ns; +463.855ns] or [+7.646%; +9.107%]

scenario:iast_aspects-ospathnormcase_aspect

  • 🟥 execution_time [+233.082ns; +275.837ns] or [+9.319%; +11.028%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+685.958ns; +754.884ns] or [+17.424%; +19.174%]

@erikayasuda erikayasuda reopened this Nov 21, 2024
@erikayasuda
Copy link
Contributor

/merge

Copy link
Contributor Author

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/apm-core-python

@dd-devflow
Copy link

dd-devflow bot commented Nov 21, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-21 22:33:11 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in 2.17 is 0s.


2024-11-22 00:33:51 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build took longer than expected. The current limit for the base branch '2.17' is 120 minutes.

Possible reasons:

  • target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants