Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicole cybul/vertex ai integration llmobs #11459

Draft
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

ncybul
Copy link
Contributor

@ncybul ncybul commented Nov 20, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

ncybul and others added 30 commits October 30, 2024 16:06
Copy link
Contributor

github-actions bot commented Nov 20, 2024

CODEOWNERS have been resolved as:

.riot/requirements/1d47606.txt                                          @DataDog/apm-python
.riot/requirements/353a75e.txt                                          @DataDog/apm-python
.riot/requirements/3ad56f1.txt                                          @DataDog/apm-python
.riot/requirements/722335d.txt                                          @DataDog/apm-python
tests/contrib/vertexai/test_vertexai_llmobs.py                          @DataDog/ml-observability
ddtrace/contrib/internal/vertexai/_utils.py                             @DataDog/ml-observability
ddtrace/contrib/internal/vertexai/patch.py                              @DataDog/ml-observability
ddtrace/llmobs/_constants.py                                            @DataDog/ml-observability
ddtrace/llmobs/_integrations/vertexai.py                                @DataDog/ml-observability
ddtrace/llmobs/_llmobs.py                                               @DataDog/ml-observability
riotfile.py                                                             @DataDog/apm-python
tests/contrib/vertexai/conftest.py                                      @DataDog/ml-observability

@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2024

Benchmarks

Benchmark execution time: 2024-11-24 22:25:40

Comparing candidate commit 78a27e9 in PR branch nicole-cybul/vertex-ai-integration-llmobs with baseline commit 7297779 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 295 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathjoin_aspect

  • 🟩 execution_time [-763.365ns; -722.706ns] or [-12.964%; -12.274%]

@ncybul ncybul changed the base branch from main to nicole-cybul/vertex-ai-integration November 20, 2024 18:55
Base automatically changed from nicole-cybul/vertex-ai-integration to main November 21, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants