-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ratchet integration #3115
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (82.89%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3115 +/- ##
============================================
+ Coverage 73.03% 73.20% +0.17%
- Complexity 2792 2852 +60
============================================
Files 140 141 +1
Lines 15372 15640 +268
Branches 1067 1067
============================================
+ Hits 11227 11450 +223
- Misses 3587 3632 +45
Partials 558 558
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2025-03-07 17:47:12 Comparing candidate commit 5ded6a4 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics. scenario:TraceSerializationBench/benchSerializeTrace
|
37fc427
to
7946246
Compare
Signed-off-by: Bob Weinand <[email protected]>
if ($isClose && $message->getOpcode() !== Frame::OP_CLOSE) { | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you enlighten me on the reason behind this condition? Not saying by any means that it is wrong. Just trying to understand. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\DDTrace\install_hook($onControl, $hookFn(true), null, \DDTrace\HOOK_INSTANCE);
This hook - with $isClose === true:
$onControl is called for any control opcode, including pings and pongs for example. We are only interested in close frames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably should rename this to $isControl
, then it becomes more obvious.
7946246
to
5ded6a4
Compare
Implements server (cboden/ratchet) and clients (ratchet/pawl) of ratchet.
This is going to be the basis of further integrations in conjunction with event loops.