-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-app][CIAPP-936] Add More Git Metadata to Tests #1254
Conversation
@rochdev I'll delay this a bit to see if the maintainer of |
* copy index.js from repository and adjust * add file to eslintignore
@rochdev I've added the single logic file from |
.eslintignore
Outdated
@@ -6,3 +6,4 @@ node_modules | |||
protobuf | |||
versions | |||
acmeair-nodejs | |||
packages/dd-trace/src/plugins/util/git-repo-info.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move this to a vendor folder instead and ignore the entire folder?
@@ -0,0 +1,356 @@ | |||
// From https://github.com/rwjblue/git-repo-info/blob/d3ab418ef8b392eabbe911a37871708b15201b70/index.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file should also be added to LICENSE-3rdparty.csv
similar to the TDigest entry.
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
+ Coverage 92.56% 92.58% +0.02%
==========================================
Files 150 150
Lines 6095 6113 +18
==========================================
+ Hits 5642 5660 +18
Misses 453 453
Continue to review full report at Codecov.
|
What does this PR do?
git-repo-info
which reads from the.git
folder and does not rely ongit
command.git-repo-info
to add commit message, author date, name and email, and committer date, name and email to all tests.Motivation
Be able to show rich commit metadata for clients that do not use our instrumented CIs
Plugin Checklist
Additional Notes